← Back to team overview

yellow team mailing list archive

Re: Add support for _annotation calls to env. (issue 7064060)

 

Land with changes.

Looks good to me.  Thank you!

Gary


https://codereview.appspot.com/7064060/diff/1/app/store/env.js
File app/store/env.js (right):

https://codereview.appspot.com/7064060/diff/1/app/store/env.js#newcode276
app/store/env.js:276: * @param {Object} entity The name of a machine,
unit, service, or
Would be nice to specify what the name of these things is--examples.

https://codereview.appspot.com/7064060/diff/1/app/store/env.js#newcode307
app/store/env.js:307: *   environment.
You don't describe the keys argument.  Given that it appears to be
optional, it would be particularly nice to document.

https://codereview.appspot.com/7064060/

-- 
https://code.launchpad.net/~bac/juju-gui/1096230/+merge/142513
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~bac/juju-gui/1096230 into lp:juju-gui.


References