← Back to team overview

yellow team mailing list archive

Re: Add support for _annotation calls to env. (issue 7064060)

 

lgtm, one minor of note


https://codereview.appspot.com/7064060/diff/5001/app/store/env.js
File app/store/env.js (right):

https://codereview.appspot.com/7064060/diff/5001/app/store/env.js#newcode296
app/store/env.js:296: *   callback.  The invocation of this command
returns nothing.
the doc string should also have a note that annotations come back in the
delta stream so explicit fetching should be rarely be needed or unesc.

https://codereview.appspot.com/7064060/

-- 
https://code.launchpad.net/~bac/juju-gui/1096230/+merge/142513
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~bac/juju-gui/1096230 into lp:juju-gui.


References