zeitgeist team mailing list archive

[Siegfried Gevatter <rainct@xxxxxxxxxx>]

Review: Needs Fixing
> "lambda : "
The space before the colons looks ugly :P.

> "except:"
Please make this "except sqlite3.foobar" (or, worst-case, "except Exception").
Also, why do you need the rollback there?

> "A storage medium is indetified by a key"
How can I indetify you? :)

You could move most the the NM/Connman code into a common base class.

Looks great otherwise. Good job!!!
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/storagemonitor2/+merge/49212
Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/storagemonitor2.