zeitgeist team mailing list archive

Thread
Date

Re: [Merge] lp:~zeitgeist/zeitgeist/storagemonitor2 into lp:zeitgeist

To: Mikkel Kamstrup Erlandsen <mikkel.kamstrup@xxxxxxxxx>
From: Siegfried Gevatter <rainct@xxxxxxxxxx>
Date: Mon, 14 Mar 2011 22:12:51 -0000
In-reply-to: <20110210123135.15058.75291.launchpad@loganberry.canonical.com>
Reply-to: mp+49212@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve
Alright, I've tested it with Network Manager and it seems to work fine. Awesome work!

Since I love nitpicking so much, "self._up ()" could be changed to "self._up()" :P. But anyway, I think this is ready to merge as soon as dbschema4 goes in (outstanding issues for that are deciding what to do with 0.7 compatibility, merging Seif's move tracking and deciding if we like Markus' cache deletion workaround - am I forgetting anything?).
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/storagemonitor2/+merge/49212
Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/storagemonitor2.

References

[Merge] lp:~zeitgeist/zeitgeist/storagemonitor2 into lp:zeitgeist
From: Mikkel Kamstrup Erlandsen, 2011-02-10