zeya team mailing list archive

[Amit Saha <lists.amitsaha@xxxxxxxxx>]

Hi Phil:

Phil Sung wrote:
> On Sat, Jan 2, 2010 at 01:36, Amit Saha <lists.amitsaha@xxxxxxxxx> wrote:
> > Done. Pls. find the patch and the m3u.py file attached.
>
> Thanks! (It works great, by the way.) I applied it after minor
> formatting cleanups and the following changes:
>
> * Fixed unit tests.
> * Fixed formatting of error messages in a couple of places (some ","s
> needed to be replaced with "%"s).
> * Moved some error-handling code from M3uBackend.__init__ to
> M3uBackend.get_library_contents, since the error handling for
> unreadable playlist files might as well be done at the time we're
> actually attempting to read the file.

Thanks for the effort. I will do better with my patches next time on.

> I've pushed this to my 'm3u-playlists' branch. If you could take a
> look at it and check that I didn't mess anything up then I will merge
> it.

Things look great. Please merge it!


Best Regards,
Amit
> > Thanks for that point. I shall do that when I have some time and probably
> > when I add the PLS support.
>
> Ok.
>
> Cheers,
> Phil


--
Journal: http://amitksaha.wordpress.com
µ-blog: http://twitter.com/amitsaha
IRC: cornucopic on #scheme, #lisp, #math, #linux