zorba-coders team mailing list archive

[Chris Hillery <959075@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The Zorba API defines Zorba_SerializerOptions, which contains values for
all known serialization parameters (and typedefs enums for all legal
values for those parameters). It also contains a method to convert
string parameters/values appropriately.

The Zorba serializer (src/api/serialization/serializer.cpp) does not use
this class, however. It defines an entirely redundant set of variables
and enums for all these values, and an entirely redundant method to
convert parameter/value strings. Then, there is
src/api/serializerimpl.cpp, which contains methods to convert between
those enums, but also ludicrously contains setSerializationParameters()
which converts Zorba_SerializerOptions to internal serializer values by
turning the enum values back into string parameter/value pairs and
passing them to the internal serializer. This is a great deal of wasted
code, and it makes adding new serialization parameters a nightmare.

** Affects: zorba
     Importance: Medium
     Assignee: Chris Hillery (ceejatec)
         Status: New

** Changed in: zorba
   Importance: Undecided => Medium

** Changed in: zorba
     Assignee: (unassigned) => Chris Hillery (ceejatec)

-- 
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/959075

Title:
  serializer should accept/use Zorba_SerializerOptions

Status in Zorba - The XQuery Processor:
  New

Bug description:
  The Zorba API defines Zorba_SerializerOptions, which contains values
  for all known serialization parameters (and typedefs enums for all
  legal values for those parameters). It also contains a method to
  convert string parameters/values appropriately.

  The Zorba serializer (src/api/serialization/serializer.cpp) does not
  use this class, however. It defines an entirely redundant set of
  variables and enums for all these values, and an entirely redundant
  method to convert parameter/value strings. Then, there is
  src/api/serializerimpl.cpp, which contains methods to convert between
  those enums, but also ludicrously contains
  setSerializationParameters() which converts Zorba_SerializerOptions to
  internal serializer values by turning the enum values back into string
  parameter/value pairs and passing them to the internal serializer.
  This is a great deal of wasted code, and it makes adding new
  serialization parameters a nightmare.

To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/959075/+subscriptions