← Back to team overview

zorba-coders team mailing list archive

Thread
Date

Re: [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba

To: mp+114739@xxxxxxxxxxxxxxxxxx
From: Markos Zaharioudakis <markos_za@xxxxxxxxx>
Date: Fri, 13 Jul 2012 04:02:20 -0000
In-reply-to: <20120712212216.9529.76774.launchpad@ackee.canonical.com>
Reply-to: mp+114739@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Till, did you really have a case where the "swap" local var was needed? I think I can see why it is needed, but I think the code in item_handle should be changed (call addReference() before remveReference()) to make "swap" unecessary. Do you agree?
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114739
Your team Zorba Coders is subscribed to branch lp:zorba.

References

[Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
From: Till Westmann, 2012-07-12