← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

 

Ghislain, you changed the StructuralAnyUriItem constructor to take a const zstring&, instead of zstring&. I prefer that you revert this change (because the old way is more consistent with the rest of the item factory methods), but if want to keep the "const" it's ok, but then the use of the temp zstring variable in methods inAncestor, isFollowing, etc is no longer needed (in both their StructuralAnyUriItem and AnyUriItem versions). The static_cast of the aOther param in those methods is also not needed any more.


-- 
https://code.launchpad.net/~zorba-coders/zorba/structural-any-uri-lazy/+merge/104918
Your team Zorba Coders is subscribed to branch lp:zorba.


References