← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba

 

Review: Needs Information

General question: Is there a reason you created ZorbaIOStream rather
than using normal C++ iostreams? It seems like re-inventing the wheel,
and it also makes it harder to use this feature with streams from
other sources.

Also, comments in swig/Item.h are inaccurate -
  a. Both functions say "returns a string", but they are void
  b. Second function also has a @return note

I'll withhold further comments until hearing about using iostreams,
though...

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194
Your team Zorba Coders is subscribed to branch lp:zorba.


References