← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba

 

Review: Needs Fixing

Isn't the following method wrong? You need to check that the strings are the same not just a subset one of another. Just say:
  return (test == null && query.result == null) || test.equals(queryRTesult);

2068    + static boolean checkResult(String test, String queryResult) {
2069	+ System.out.println("Result:");
2070	+ System.out.println(queryResult);
2071	+ System.out.println("Expected:");
2072	+ System.out.println(test);
2073	+ return (queryResult.indexOf(test)>=0) || (test.indexOf(queryResult)>=0);
2074	+ }
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug938320/+merge/118194
Your team Zorba Coders is subscribed to branch lp:zorba.


References