zorba-coders team mailing list archive

[Chris Hillery <chillery+launchpad@xxxxxxxxx>]

Review: Needs Fixing

1. Error QNames should not be declared as public constants (see coding guidelines). Declare them as private variables as follows:

declare %private variable $queue:NOT-EXISTS as xs:QName := fn:QName($queue:ERR-NS, "queue:NOT-EXISTS");

2. The current XQDoc for those error QNames is pointless. Either eliminate the XQDoc entirely, or put in some meaningful comment (only for later authors of the module since it won't be part of the public API).

3. The XQDoc for all the queue functions refers to "nodes". It should now say "items" since it works for objects and arrays in addition to nodes.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946
Your team Zorba Coders is subscribed to branch lp:zorba/queue-module.