← Back to team overview

zorba-coders team mailing list archive

Re: [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

 

Review: Needs Fixing

Basically the same comments as the queue proposal:

1. Make the error QName variables %private;
2. Fix or eliminate the XQDoc for the error QNames;
3. Replace "node" with "item" in function XQDoc.

In addition:

4. You have a stray <p> at the beginning of the header XQDoc comment (diff line 21).

5. You have </p> in at least 8 places, instead of <p/>.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
Your team Zorba Coders is subscribed to branch lp:zorba/stack-module.


References