banking-addons-team team mailing list archive

[James Jesudason <james.jesudason@xxxxxxxxxxxxx>]

On 18/02/12 15:21, Stefan Rijnhart wrote:
> On 18-02-12 00:52, James Jesudason wrote:
> > I've pushed the branch as requested. There's still more to do, but
> > most of the screens are loading and I have bank statement imports
> > working (at least for HSBC). I'll continue next week.
>
> I see that you are reintroducing the 'iban' field. To better support
> existing installations, I would suggest an approach to add a field
> 'acc_number_domestic' instead. Otherwise, OpenERP databases with the
> banking addons installed need a different upgrade path than databases
> without them. See
> http://bazaar.launchpad.net/~openupgrade-committers/openupgrade-addons/6.1/view/head:/base_iban/migrations/6.1.1.0/pre-migration.py
>
>
> I will suggest a branch to work this out. Hope that you can agree.

I think I misunderstood your response earlier when I asked about 
retaining the 'iban' field. I thought that you wanted to keep it. I'm 
happy to remove it and just use the 'acc_number' field.

Do you think we still need the 'acc_number_domestic' field?

James