banking-addons-team team mailing list archive

[Stefan Rijnhart <stefan@xxxxxxxx>]

On 02/20/2012 10:05 AM, James Jesudason wrote:
> I think I misunderstood your response earlier when I asked about 
> retaining the 'iban' field. I thought that you wanted to keep it. I'm 
> happy to remove it and just use the 'acc_number' field.
>
> Do you think we still need the 'acc_number_domestic' field?

Hi James,

sorry about the confusion. It is indeed the case that we need to 
preserve the domestic account field for a smooth transition to IBAN in 
the near future, at least in my region. However, 6.1 preserves the 
'iban' field as an unstored related field on 'acc_number'. This can 
hardly be overridden by another module, as an upgrade of the 'base' 
module will always trigger that the column be dropped. Also, for 
compatibility with other modules I thought it be best that the 
'acc_number' hold the IBAN when state == 'iban'.

The following branch implements this behaviour, holding the domestic 
account number in 'acc_number_domestic' if and only if state == 'iban'.

https://code.launchpad.net/~therp-nl/banking-addons/6.1-dev-preserve-domestic/+merge/93746

If it looks alright to you, please merge it with your branch.

Regards,
Stefan.


--
Therp - Maatwerk in open ontwikkeling

Stefan Rijnhart - Ontwerp en implementatie

mail: stefan@xxxxxxxx
tel: +31 (0) 614478606
http://therp.nl
https://twitter.com/therp_stefan