c2c-oerpscenario team mailing list archive

["sraps \(Alistek\)" <726690@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

There are several design faults with "decimal_precision" module.
Quote from module description:
-----------------------
This module allows to configure the price accuracy you need for different kind
of usage: accounting, sales, purchases, ...

The decimal precision is configured per company.
-----------------------
Fault #1:
Although it states that there is an option to set decimal precision per company, the model "decimal.precision" has no company field. It is the same when you observe the functionality in use by several other modules, like accounting, because it initializes the classes per database, not per company (IMHO it is impossible), evidently the functionality stated in the description is not being performed.

Fault #2:
When we see the float field definition there is such thing as 2 parameters - the number before decimal separator and the number after, still the model "decimal.precision" has only one field - digits.

Fault #3:
Normally you should not use language specific capitalized strings with spaces inside as codes for matching the particular setting, still there is "Sale Price", "Purchase Price", "Account", "Stock Weight", "Product UoM", "Shipping Delay". Which is amateurish coding style. This is not according to conventions in the other places with OpenERP, for example with properties, where you can observe completely opposite situation, for example - "property_account_receivable".

** Affects: openobject-addons
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/726690

Title:
  Module "decimal_precision" faulty by design

Status in OpenERP Modules (addons):
  New

Bug description:
  There are several design faults with "decimal_precision" module.
  Quote from module description:
  -----------------------
  This module allows to configure the price accuracy you need for different kind
  of usage: accounting, sales, purchases, ...

  The decimal precision is configured per company.
  -----------------------
  Fault #1:
  Although it states that there is an option to set decimal precision per company, the model "decimal.precision" has no company field. It is the same when you observe the functionality in use by several other modules, like accounting, because it initializes the classes per database, not per company (IMHO it is impossible), evidently the functionality stated in the description is not being performed.

  Fault #2:
  When we see the float field definition there is such thing as 2 parameters - the number before decimal separator and the number after, still the model "decimal.precision" has only one field - digits.

  Fault #3:
  Normally you should not use language specific capitalized strings with spaces inside as codes for matching the particular setting, still there is "Sale Price", "Purchase Price", "Account", "Stock Weight", "Product UoM", "Shipping Delay". Which is amateurish coding style. This is not according to conventions in the other places with OpenERP, for example with properties, where you can observe completely opposite situation, for example - "property_account_receivable".