cairo-dock-team team mailing list archive

[Fabounet <fabounet03@xxxxxxxxx>]

Hi,
you're absolutely right, thank you for this patch !  :-)

** Changed in: cairo-dock-core
   Importance: Undecided => High

** Changed in: cairo-dock-core
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Cairo-
Dock Team, which is subscribed to Cairo-Dock Core.
https://bugs.launchpad.net/bugs/1050399

Title:
  no-return-in-nonvoid-function

Status in Cairo-Dock : Core:
  Fix Committed

Bug description:
  1) in file cairo-dock-desklet-factory.c "gboolean cairo_dock_detach_icon_from_desklet (Icon *icon, CairoDesklet *pDesklet)" needs "return TRUE;" at the end.
  2) in file cairo-dock-dock-factory.c "static gboolean _on_dock_destroyed (GtkWidget *menu, CairoContainer *pContainer)" needs "return CAIRO_DOCK_LET_PASS_NOTIFICATION;" (I'm not sure. someone must check it) at the end.
  3) in file cairo-dock-file-manager.c "static gpointer _cairo_dock_fm_launch_uri_threaded (gchar *cURI)" needs "return NULL;" at the end.
  4) in file cairo-dock-module-manager.c "static gboolean _write_modules (gpointer data)" return value should be changed to void.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cairo-dock-core/+bug/1050399/+subscriptions