cairo-dock-team team mailing list archive

[Michael Tautschnig <mt@xxxxxxxxxx>]

Public bug reported:

Here's another result from our build with link-time type checking: there
are conflicting declarations of the variable g_pPrimaryContainer as
follows:

./src/gldit/cairo-dock-container.c:CairoContainer *g_pPrimaryContainer = NULL;
./src/gldit/cairo-dock-manager.c:extern CairoDock *g_pPrimaryContainer;

All other code properly declares g_pPrimaryContainer as extern
CairoContainer it seems, just cairo-dock-manager is off. Likely this is
a cosmetic issue at present only as cairo-dock-manager.c only performs a
comparison to NULL, but future more elaborate use of the variable will
lead to undefined behaviour.

Best,
Michael

** Affects: cairo-dock-core
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Cairo-
Dock Team, which is subscribed to Cairo-Dock Core.
https://bugs.launchpad.net/bugs/1055136

Title:
  Conflicting declaration of g_pPrimaryContainer

Status in Cairo-Dock : Core:
  New

Bug description:
  Here's another result from our build with link-time type checking:
  there are conflicting declarations of the variable g_pPrimaryContainer
  as follows:

  ./src/gldit/cairo-dock-container.c:CairoContainer *g_pPrimaryContainer = NULL;
  ./src/gldit/cairo-dock-manager.c:extern CairoDock *g_pPrimaryContainer;

  All other code properly declares g_pPrimaryContainer as extern
  CairoContainer it seems, just cairo-dock-manager is off. Likely this
  is a cosmetic issue at present only as cairo-dock-manager.c only
  performs a comparison to NULL, but future more elaborate use of the
  variable will lead to undefined behaviour.

  Best,
  Michael

To manage notifications about this bug go to:
https://bugs.launchpad.net/cairo-dock-core/+bug/1055136/+subscriptions