← Back to team overview

calibre-devs team mailing list archive

Re: lp:~llasram/calibre/oeb2lit ready for merge

 

I'm still getting the 32bit error. For the rest of my comments see below. 

Traceback (most recent call last):
File "/home/kovid/work/calibre/src/calibre/gui2/viewer/main.py", line 55, in 
run
Thread.run(self)
File "/usr/lib/python2.6/threading.py", line 477, in run
self.__target(*self.__args, **self.__kwargs)
File "/home/kovid/work/calibre/src/calibre/ebooks/epub/iterator.py", line 114, 
in __enter__
self.pathtoopf = self.to_opf(self.pathtoebook, self.base, opts)
File "/home/kovid/work/calibre/src/calibre/ebooks/epub/from_any.py", line 26, 
in lit2opf
reader.extract_content(tdir, False)
File "/home/kovid/work/calibre/src/calibre/ebooks/lit/reader.py", line 837, in 
extract_content
f.write(self.get_entry_content(entry, pretty_print))
File "/home/kovid/work/calibre/src/calibre/ebooks/lit/reader.py", line 807, in 
get_entry_content
raw = self.get_file(name)
File "/home/kovid/work/calibre/src/calibre/ebooks/lit/reader.py", line 702, in 
get_file
section = self.get_section(entry.section)
File "/home/kovid/work/calibre/src/calibre/ebooks/lit/reader.py", line 708, in 
get_section
data = self._get_section(section)
File "/home/kovid/work/calibre/src/calibre/ebooks/lit/reader.py", line 730, in 
_get_section
content = self._decompress(content, control, reset_table)
File "/home/kovid/work/calibre/src/calibre/ebooks/lit/reader.py", line 778, in 
_decompress
raise LitError("Reset table entry greater than 32 bits")
LitError: Reset table entry greater than 32 bits

Kovid.

On Tuesday 16 December 2008 16:07:45 Marshall T. Vandegrift wrote:
> On Tue, Dec 16, 2008 at 5:28 PM, Kovid Goyal <kovid@xxxxxxxxxxxxxx> wrote:
> > oeb.py currently errors out if the OPF file contains items in the
> > manifest that dont exist.
>
> Hmm.  I kind of think that's an error OEB-processing code should fail on,
> but changed to a warning + work-around, along with a few similar
> conditions.
>

Good, I'll get around to making sure any2epub doesn't produce invalid links in 
the OPF later, but this will allow me to ship any2lit now.

> In order to log those warnings, I modified how LitWriter does logging too.
> Instead of Having the LitWriter inherit from the LoggingInterface, both the
> LitWriter and the OEBBook are passed the same LoggingInterface object --
> which seems more Pythonic to me anyway.  It would seem even better to me
> then if the calibre logging objects could just provide the same interface
> as logging.Logger objects.
>

Since the interface is designed to be inherited, I didn't want to use common 
names like warn, error etc.


> > Also html2epub now splits on page breaks by default, so please add an
> > option to oeb2lit to disable splitting.
>
> Nothing in oeb2lit actually does splitting -- it just finds CSS-specified
> page-breaks and adds their locations to on of the LIT indices.  I don't
> think disabling that will help with much (we still need CSS processing to
> identify block tags and areas of 'white-space: pre').
>

OK, my mistake, I thought you were doing splitting. All changes, including 
fontconfig merged. 

Incidentally, since you have a 64bit machine could you test the binary calibre 
installer. I changed the freezing process recently and I'm getting reports it 
doesn't work on 64bits. 

> Above changes available in lp:~llasram/calibre/staging revision 1992.
>
> -Marshall
>
> _______________________________________________
> Mailing list: https://launchpad.net/~calibre-devs
> Post to     : calibre-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~calibre-devs
> More help   : https://help.launchpad.net/ListHelp
>
> !DSPAM:3,494842d875726406588822!

-- 
_____________________________________

Kovid Goyal  MC 452-48
California Institute of Technology
1200 E California Blvd
Pasadena, CA 91125

cell  : +01 626 390 8699
office: +01 626 395 6595 (449 Lauritsen)
email : kovid@xxxxxxxxxxxxxxxxxx
web   : http://www.kovidgoyal.net
_____________________________________




Follow ups

References