cloud-init-dev team mailing list archive

[Joshua Powers <josh.powers@xxxxxxxxxxxxx>]

Review: Approve

LGTM, with two minor comments below. Reusing images has really sped up execution and printing the cloud-init version is great. I ran through the following tests:

$ tox
$ tox -e citest -- run -v -n zesty -t tests/cloud_tests/configs/modules/write_files.yaml
$ tox -e citest_new_pylxd -- run -v -n zesty -t tests/cloud_tests/configs/modules/write_files.yaml
$ tox -e citest_tree_run
$ python3 -m tests.cloud_tests run -v -n zesty -t tests/cloud_tests/configs/modules/write_files.yaml
$ python3 -m tests.cloud_tests run -v -n stretch -t tests/cloud_tests/configs/modules/write_files.yaml
$ python3 -m tests.cloud_tests run -v -n jessie -t tests/cloud_tests/configs/modules/write_files.yaml

Comment 1:
The warning messages about using pylxd < 2.2 [1]. There are far too many messages right now. I see the message in pylxd.py as it checks for the exit code; can we suppress the warning until 2.2 is stable or even consider changing it to show up when the user is using less than 2.1.3? 

Comment 2:
Running on jessie I get a failure running no_stages_errors [2] about security. Is it trying to add the jessie security repo?

[1] https://paste.ubuntu.com/23817502/
[2] https://paste.ubuntu.com/23817710/

-- 
https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/308218
Your team cloud init development team is requested to review the proposed merge of ~wesley-wiedenmeier/cloud-init:integration-testing into cloud-init:master.