coapp-developers team mailing list archive

[Olaf van der Spek <olafvdspek@xxxxxxxxx>]

On Wed, Aug 4, 2010 at 6:24 PM, Ted Bullock <tbullock@xxxxxxxxxxx> wrote:
>>> '\\ No newline at end of file'
>>
>> Might be a good idea to add this newline to every file. A shame VS
>> doesn't do this by default...
>
> Is this really important? Why would we need a new line at the end of the file?

No, but http://bazaar.launchpad.net/~tbullock/coapp-engine/experiment/revision/1#chip/chip.c
mentions it.

>> libcoapp/coapp.c:
>>> #define _COMPILING_COAPP_H
>>
>> Shouldn't this be defined on project level?
>
> No, it is included in every internal .c file and is responsible for
> making sure that the dll_export/dll_import stuff is correctly
> specified.

Isn't it easier to do this once on project level?

>>> static enum coapp_error coapperr = COAPP_SUCCESS;
>>
>> What's this?
>> Shouldn't globals have a g_ prefix?
>
> I do not believe in hungarian notation.  Also this will go away. It
> was a passing thought on how to manage errors, except it isn't thread
> safe. I have some other ideas.

Prefixing globals is not about Hungarian notation.

Olaf