← Back to team overview

cuneiform team mailing list archive

Re: Patch to build in MSVC++ 6 and pack mode in cuneiform-cli

 

 Can you give some more information about problem with output file
/dev/stdout?

I use "ugly" style because it save logic, but it's only IMHO. I move "int i"
upwards (in my new patch).

In attach:
fix.for_scope.patch - change for variable scope for MSVC++ 6
fix.vc9.patch - patch for building revision 339 under VC++ 9 (with
suppresion massive warning)

2009/1/13 Jussi Pakkanen <jpakkane@xxxxxxxxx>

> On Tue, Jan 13, 2009 at 4:37 PM, Yury V. Zaytsev <yury@xxxxxxxxxx> wrote:
>
> >> However adding extra braces is very, very ugly. If we want to support
> >> MSVC 6 the way to go is to move "int i" upwards so that both loops use
> >> the same i.
> >
> > for (int i = 0; i < foo; i++) {
> >    do_something();
> > }
> >
> > doesn't look all that bad for me.
>
> No it doesn't. But the patch had this:
>
> {for(int i=0; i<foo; i++) do_something();}
> {for(int i=0; i<foo; i++) do_something_else();}
>
> Rather than
>
> int i;
> for(i=0; i<foo; i++) do_something();
> for(i=0; i<foo; i++) do_something_else();
>
>
> And the same for larger loops.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cuneiform<https://launchpad.net/%7Ecuneiform>
> Post to     : cuneiform@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~cuneiform<https://launchpad.net/%7Ecuneiform>
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: fix.for_scope.patch
Description: Binary data

Attachment: fix.vc9.patch
Description: Binary data


Follow ups

References