← Back to team overview

desktop-packages team mailing list archive

[Bug 1441623] [NEW] optimize ofono context property-changed logic

 

Public bug reported:

This bug is bring reported as of network-manager version
0.9.10.0-4ubuntu13 ( latest in vivid at bug filing time ).

The code in src/devices/wwan/nm-modem-ofono.c which handles context
property_change signals should be optimized.

The function context_properties_changed() watches for key == 'Settings',
and then calls ofono_context_get_ip_properties().  This function then
calls dbus_g_proxy_call_with_timeout() to invoke the 'GetProperties'
method of the context interface.  This is a synchronous DBus call which
really isn't necessary as the payload for the 'PropertyChanged' signal
already contained the required data ( ie. the IP settings ).

** Affects: network-manager (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to network-manager in Ubuntu.
https://bugs.launchpad.net/bugs/1441623

Title:
  optimize ofono context property-changed logic

Status in network-manager package in Ubuntu:
  New

Bug description:
  This bug is bring reported as of network-manager version
  0.9.10.0-4ubuntu13 ( latest in vivid at bug filing time ).

  The code in src/devices/wwan/nm-modem-ofono.c which handles context
  property_change signals should be optimized.

  The function context_properties_changed() watches for key ==
  'Settings', and then calls ofono_context_get_ip_properties().  This
  function then calls dbus_g_proxy_call_with_timeout() to invoke the
  'GetProperties' method of the context interface.  This is a
  synchronous DBus call which really isn't necessary as the payload for
  the 'PropertyChanged' signal already contained the required data ( ie.
  the IP settings ).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1441623/+subscriptions


Follow ups

References