dhis2-devs team mailing list archive

[Lars Helge Øverland <larshelge@xxxxxxxxx>]

2009/4/18 Murodullo Latifov <murodlatifov@xxxxxxxxx>

> Ok,
>
> I will copy/paste 'easy help' and 'dataelement history' into trunk. struts2
> modules are independent of other modules, original modules are still there,
> its just a matter of removing them as <module>name</module> from poms to
> exclude from compilation, code could be there for reference. But still fine
> we can do that later.
>

Great. I will have a look soon, seems nice...



>
> 'easy help access' needs further work by manual writers. First we need to
> test it and then manual writers should add tags and translation strings
> accordingly. 'dataelement history' also needs causion, it has dependency
> which is not in maven2 repository at this time. I will commit, you can
> revert in case, is this ok?
>

Frankly I don't think we should add dependencies that are not in the central
maven repo. It makes it harder for other developers. We could set up our own
/ use the one on hisp.info, but this server has not been stable at all
lately and* *it feels better to only be dependent on the central one.

Also, I have had some second thoughts about this solution... Isn't it a
little overkill to change the persistence framework to accomplish this task?
I agree that we should not reinvent the wheel and so on but in this case it
seems just a matter of creating a DataValueModification object (or similar)
and make add- and getall- functions.

Also, this makes us dependent on Hibernate. We have seen talk of switching
the persistence layer. In that case this function must be re-implemented. If
we put it in the service layer it will remain.

Not saying I have the answer, just a little sceptical, what do you think?