← Back to team overview

dhis2-users team mailing list archive

Re: [Dhis2-devs] Loop hole in updating data values for completed Data Sets

 

Thanks Alcantara for further explanation.

I have not seen such an issue in JIRA, is it being resolved? or what was
agreed on this.


*Regards,*
*Dennis*

On 16 June 2017 at 07:56, JM Alcantara <jmalcantara1@xxxxxxxxx> wrote:

> Hi Dennis
> I understand your requirement, this has been discussed before and the
> current options are expiry days and approvals.
> You don’t actually need a full approval workflow, the approval can be used
> as a form of completion, isn’t that the same as locking when completing?
> What you certainly don’t get from the approval is the statistics you get
> from completing the data set.
>
> In your images I see the audit trail recorded the update, that seems to be
> working correctly. If you look at the example I’m including, you’ll see the
> initial value was 292, which was updated/replaced with 200, then that was
> deleted so at that point there was no value, and finally a new value 5 was
> entered, which is the current value of 5.
>
> JM
>
>
> El 15/06/2017, a las 23:04, Dennis Banga <dennisbanga@xxxxxxxxx> escribió:
>
> Thanks Alcantara. Locking might not work since we give a period of six
> months before locking the data sets, and for our case we don't have an
> approval workflow.
>
> To elaborate further on the issue, here are some screenshots I have taken
> using the demo site.
>
> 1.0 Completed Inpatient Morbidity/Mortality Summary for Ngelehum CHC -
> August 2016. ( completed at 2016-04-18)
> <image.png>
>
> 1.1 Data Set Report for the same.
>
> <image.png>
>
> 2.0 Updating the data values in the data entry form which is completed
> without incompleting first. (replaced all the values with 200)
> <image.png>
>
> (showing the POST request for the new data value)
> <image.png>
>
> 2.1 Generating the data set report after edit/update.
>
> <image.png>
>
> 2.2 The audit trial remains unchanged.
>
> <image.png>
>
>
> Hence, the data entry fields should be either disabled after the data set
> is completed or the data entry fields shouldn't update the values when the
> form is completed.
>
>
>
>
>
>
> *Regards,*
> *Dennis*
>
> On 16 June 2017 at 00:18, JM Alcantara <jmalcantara1@xxxxxxxxx> wrote:
>
>> Hi Dennis
>> I don’t recall that data sets actually lock data entry when marked
>> completed. What you can do is use expiry days or approvals, that will lock
>> the data set automatically after X days or lock it by having the user
>> approve the data.
>> Best regards,
>> JM
>>
>> El 15/06/2017, a las 13:34, Dennis Banga <dennisbanga@xxxxxxxxx>
>> escribió:
>>
>> Thanks David for the prompt response.
>>
>> I have checked the issue you have linked to, but this is different to the
>> issue I have reported since its about compulsory data elements not being
>> enforced when completing a data set. My issue is that you can update values
>> once the data set is completed which is not supposed to be the case.
>>
>>  I had checked if there was a similar issue reported, the one that
>> closely matched was -DHIS2-1079
>> <https://jira.dhis2.org/browse/DHIS2-1079> but was on the Android app.
>>
>>
>> *Regards,*
>> *Dennis*
>>
>> On 15 June 2017 at 21:06, David Muturi <dnmuturi@xxxxxxxxx> wrote:
>>
>>> Hi Dennis,
>>> This is a know dhis2 bug see  dhis2 JIRA link (DHIS2-1362
>>> <https://jira.dhis2.org/browse/DHIS2-1362>).
>>> rgds
>>> David
>>>
>>> 2017-06-15 20:50 GMT+03:00 Dennis Banga <dennisbanga@xxxxxxxxx>:
>>>
>>>> Greetings,
>>>>
>>>> Here is an issue we have noted, on the data entry form I can update
>>>> individual data values when the data set is completed without first
>>>> incompleting , update the values and then complete. When I run the data set
>>>> report at the same level the I can see the updated values, but on the audit
>>>> trail I can only see the first value entered.
>>>>
>>>> I don't know why this works this way or it's a system bug. I would
>>>> propose once a data set is completed the data entry fields should be
>>>> disabled in the data entry form and for any updates the user must
>>>> incomplete, update values and the complete again.
>>>>
>>>> We have seen users taking advantage of this loop hole, whereby they
>>>> complete blank data sets and then update the values later. So when running
>>>> reporting rates summary you'll see those facilities have reported which is
>>>> not the case.
>>>>
>>>> Kindly advise on this.
>>>>
>>>>
>>>> Thanks,
>>>>
>>>>
>>>> Dennis
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~dhis2-devs
>>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~dhis2-devs
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dhis2-users
>> Post to     : dhis2-users@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-users
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>
>

JPEG image


References