← Back to team overview

dolfin team mailing list archive

Re: [HG DOLFIN] Fix bug in init: only init when needed. Unit tests work again now.

 

On Thu, Nov 20, 2008 at 11:26:20PM +0000, Garth N. Wells wrote:
> 
> 
> Kristian Oelgaard wrote:
> > 
> > Should be fixed now. BTW, I ran the test/memory/test.py and there seem to be
> > leaks a plenty...
> >
> 
> These are all fixed now. Since this test is now all clear for the very 
> *first* time (thanks to the use of shared_ptr to resolve the tricky 
> issues), so perhaps we can have the buildbot run it?

Yes.

> I did have to fish out a few leaks, all due to 'new' without a matching 
> 'delete'. I suggest that we use auto_ptr or other smart pointers 
> whenever possible to avoid this. 'delete' seems simple, but new/delete 
> regularly leads to problems and isn't elegant for functions with 
> multiple return statements.

Sounds good.

-- 
Anders

Attachment: signature.asc
Description: Digital signature


References