← Back to team overview

dolfin team mailing list archive

Re: suggestion for modifying MeshGeometry

 

On Thu, Apr 09, 2009 at 09:01:32AM -0400, Shawn Walker wrote:
> ok, I will make everything lower case and using underscores.
> 
> I'll also change it to 'higher_order_vertices'.  Eventually, the data 
> structure should be made more general, but for the moment I think we 
> should just stick with P2 triangles and see how that works with UFC and 
> eventually FFC.

Sounds good.

> On Thu, 9 Apr 2009, Garth N. Wells wrote:
> >> 
> >> Should it be <higher_order_vertices> in the XML format? The tag
> >> contains a list of vertices.
> >> 
> >
> > Are they really vertices?

Yes, in some sense they are. We could extend the XML format, but it
currently reuses the <vertex> and <cell> tags for coordinates and
cell mappings which seems both convenient and natural:

    <higher_order_vertices size="9">
      <vertex index="0" x="0.0"  y="0.0"/>
      <vertex index="1" x="1.0"  y="0.0"/>
      <vertex index="2" x="0.0"  y="1.0"/>
      <vertex index="3" x="-1.0" y="0.0"/>
      <vertex index="4" x="0.6"  y="0.6"/>
      <vertex index="5" x="0.0"  y="0.5"/>
      <vertex index="6" x="0.5"  y="0.05"/>
      <vertex index="7" x="-0.5" y="0.5"/>
      <vertex index="8" x="-0.5" y="0.0"/>
    </higher_order_vertices>

    <higher_order_cells size="2" num_dof="6">
      <cell index="0" affine="true"  v0="3" v1="0" v2="2" v3="5" v4="7" v5="8"/>
      <cell index="1" affine="false" v0="0" v1="1" v2="2" v3="4" v4="5" v5="6"/>
    </higher_order_cells>

-- 
Anders


> >> There's also a mix of under_score and camelCase in the MeshGeometry
> >> class. It would be better to just use under_score (for next patch).
> >> 
> >
> > We should aim to make this consistent throughout (i.e. use under_score) for 
> > the next DOLFIN release.
> >
> > Garth
> >
> >> It looks good although I haven't looked at it in much detail.
> >> 
> >> 
> >> 
> >> ------------------------------------------------------------------------
> >> 
> >> _______________________________________________
> >> DOLFIN-dev mailing list
> >> DOLFIN-dev@xxxxxxxxxx
> >> http://www.fenics.org/mailman/listinfo/dolfin-dev
> >
> >
> >
> _______________________________________________
> DOLFIN-dev mailing list
> DOLFIN-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/dolfin-dev

Attachment: signature.asc
Description: Digital signature


References