dolfin team mailing list archive

["Garth N. Wells" <gnw20@xxxxxxxxx>]

On Mon, 2010-08-16 at 08:40 +0000, noreply@xxxxxxxxxxxxx wrote:
> ------------------------------------------------------------
> revno: 4980
> committer: Anders Logg <logg@xxxxxxxxx>
> branch nick: dolfin-dev
> timestamp: Mon 2010-08-16 10:36:06 +0200
> message:
>   Fatal error when required package UFC is not found. Is this how we should do it?

Probably not.

>   It seems strange to continue the configuration when a required package is not found.

Configuration is not a one-shot process. CMake trys to find things, then
gives the users the chance set or change options and paths.

Garth


> modified:
>   cmake/FindUFC.dolfin.cmake
> 
> 
> --
> lp:dolfin
> https://code.launchpad.net/~dolfin-core/dolfin/main
> 
> Your team DOLFIN Core Team is subscribed to branch lp:dolfin.
> To unsubscribe from this branch go to https://code.launchpad.net/~dolfin-core/dolfin/main/+edit-subscription
> differences between files attachment (revision-diff.txt)
> === modified file 'cmake/FindUFC.dolfin.cmake'
> --- cmake/FindUFC.dolfin.cmake	2010-08-11 07:44:07 +0000
> +++ cmake/FindUFC.dolfin.cmake	2010-08-16 08:36:06 +0000
> @@ -1,9 +1,15 @@
>  # Try to find UFC - the unified framework for finite element assembly
>  #
> -# This module defines
> -# UFC_FOUND - system has UFC
> -# UFC_INCLUDE_DIRS - the UFC include directory
> -# UFC_VERSION - the UFC version string (MAJOR.MINOR.MICRO)
> +# This module defines the following variables:
> +#
> +#   UFC_FOUND        - system has UFC
> +#   UFC_INCLUDE_DIRS - UFC include directory
> +#   UFC_VERSION      - UFC version string (MAJOR.MINOR.MICRO)
>  
>  include(FindPkgConfig)
>  pkg_check_modules(UFC REQUIRED ufc-1>=1.4.1)
> +
> +# UFC is a required package
> +if(NOT $UFC_FOUND)
> +  message(FATAL_ERROR "*** Unable to configure package 'UFC'.")
> +endif(NOT $UFC_FOUND)
>