← Back to team overview

dolfin team mailing list archive

Re: Patch that adds physical region support for gmsh meshes in meshconvert.py

 

On Monday March 28 2011 01:12:54 Neilen Marais wrote:
> Hi Johan,
> 
> On Fri, Mar 25, 2011 at 5:02 PM, Johan Hake <johan.hake@xxxxxxxxx> wrote:
> > On Friday March 25 2011 07:36:28 Anders Logg wrote:
> >> On Thu, Mar 24, 2011 at 11:22:19PM +0200, Neilen Marais wrote:
> >> > Hi,
> >> > 
> >> > I verified that it still produces the same mesh.xml as the unmodified
> >> > version. As far as I can tell the outputs are identical.
> >> > 
> >> > I hope this is the right place to post it, otherwise feel free to
> >> > teach me where :)
> >> 
> >> Yes, this is the right place. Someone will look at your patch and
> >> apply it.
> > 
> > Neilen!
> > 
> > Thanks for your patch! Is it possible for you to construct a unit test
> > for this converter? There is already one in:
> > 
> >  test/unit/meshconverter/python/test.py
> > 
> > for abaqus mesh. So I guess it should be straight forward to implement
> > one for gmsh too.
> 
> Yes, I could do that. Probably tomorrow or so. Will keep you posted :)

Thanks Neilen!

This is very helpful for us!

Johan

> Regards
> Neilen
> 
> > Johan
> > 
> >> --
> >> Anders
> >> 
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~dolfin
> >> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~dolfin
> >> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dolfin
> More help   : https://help.launchpad.net/ListHelp



Follow ups

References