dolfin team mailing list archive
-
dolfin team
-
Mailing list archive
-
Message #22431
Re: patch for boundary indicators (e.g. VMTK) in parallel
-
To:
Kent-Andre Mardal <kent-and@xxxxxxxxx>
-
From:
"Garth N. Wells" <gnw20@xxxxxxxxx>
-
Date:
Mon, 04 Apr 2011 10:25:02 +0100
-
Cc:
dolfin@xxxxxxxxxxxxxxxxxxx
-
In-reply-to:
<BANLkTinqhbAv5Gb9b3VyGn=d8o0oQ5q18g@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8
On 04/04/11 09:49, Kent-Andre Mardal wrote:
> I have a unit test that I can include.
>
> BTW: A couple of issues concerning this patch.
>
> 1. I have used a std::map for a global -> local mapping. I don't know if
> this
> the most efficient thing to do, but it is certainly convenient.
>
boost::unordered_map is another possibility.
> 2. The boundary indicators are read on every process because these
> arrays are small. Their dimensions are the number of cells on the
> boundary.
>
This isn't scalable - we would need an enhanced alternative.
Garth
> Kent
>
> On 4 April 2011 10:20, Garth N. Wells <gnw20@xxxxxxxxx
> <mailto:gnw20@xxxxxxxxx>> wrote:
>
> I would prefer to not apply this just yet. I'm in the process if
> re-factoring some aspects of parallel mesh functionality. Some classes
> and functions have gotten out of hand.
>
> Register a branch and a merge request so that it doesn't get forgotten.
> Unit tests are also required before patches will be applied.
>
> Garth
>
>
>
> On 04/04/11 07:52, Kent-Andre Mardal wrote:
> >
> > Please consider the attached patch.
> >
> > Kent
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~dolfin
> <https://launchpad.net/%7Edolfin>
> > Post to : dolfin@xxxxxxxxxxxxxxxxxxx
> <mailto:dolfin@xxxxxxxxxxxxxxxxxxx>
> > Unsubscribe : https://launchpad.net/~dolfin
> <https://launchpad.net/%7Edolfin>
> > More help : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> <https://launchpad.net/%7Edolfin>
> Post to : dolfin@xxxxxxxxxxxxxxxxxxx
> <mailto:dolfin@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~dolfin
> <https://launchpad.net/%7Edolfin>
> More help : https://help.launchpad.net/ListHelp
>
>
Follow ups
References