← Back to team overview

dulwich-users team mailing list archive

Re: [PATCH] Unified gzip/paster patch

 

On Sun, 2011-03-20 at 21:11 -0400, David Blewett wrote:
> On Sun, Mar 20, 2011 at 6:49 PM, David Blewett <david@xxxxxxxxxxxxxxxx> wrote:
> > On Sun, Mar 20, 2011 at 3:52 PM, David Blewett <david@xxxxxxxxxxxxxxxx> wrote:
> >> On Sat, Mar 19, 2011 at 9:50 PM, David Blewett <david@xxxxxxxxxxxxxxxx> wrote:
> >>> On Sat, Mar 19, 2011 at 9:12 PM, Jelmer Vernooij <jelmer@xxxxxxxxx> wrote:
> >>>> I'm getting two test failures now:
> >>>
> >>> Both errors are due to pkg_resources not being able to load the
> >>> entry_points successfully.
> >>
> >> I worked around this by using pkg_resources' WorkingSet class
> >> directly. It now loads up the base dulwich dir and tests the
> >> entry_points it finds in setup.py, to ensure they match up with those
> >> expected in the test file. If you don't have setuptools (and thus no
> >> paste.deploy), the whole test will be skipped.
> >
> > Updated patch; test_entry_points now checks to be sure the number of
> > found entry_points matches the expected number, as well as checking to
> > be sure their names and memory addresses match the imported versions.
> Updated patch: `make doc` now works.
Thanks!

test_entry_points is failing here now:

FAIL: test_entry_points (dulwich.tests.test_web.PasterFactoryTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "dulwich/tests/test_web.py", line 575, in test_entry_points
    self.assertEquals(test_points, self.entry_points)
AssertionError: {'cgi': <function make_cgi_application at 0x319d848>,
'transparent_proxy': <func [truncated]... != {'gzip': <function
make_gzip_filter at 0x2e92668>, 'limitinput': <function make_
[truncated]...
+ {'gzip': <function make_gzip_filter at 0x2e92668>,
+  'limitinput': <function make_limit_input_filter at 0x2e926e0>,
+  'main': <function make_app at 0x2e925f0>}
- {'cgi': <function make_cgi_application at 0x319d848>,
-  'pkg_resources': <function make_pkg_resources at 0x3446488>,
-  'proxy': <function make_proxy at 0x3371938>,
-  'static': <function make_static at 0x3446050>,
-  'test': <function make_test_app at 0x3446848>,
-  'test_slow': <function make_slow_app at 0x3446a28>,
-  'transparent_proxy': <function make_transparent_proxy at 0x3371c80>,
-  'urlparser': <function make_url_parser at 0x34466e0>,
-  'watch_threads': <function make_watch_threads at 0x34611b8

I guess we should just make sure that those entry points that need to be
there are there and ignore the other ones. It's strange that limitinput
disappears though.

Cheers,

Jelmer

Attachment: signature.asc
Description: This is a digitally signed message part


Follow ups

References