← Back to team overview

duplicity-team team mailing list archive

Re: All Merged

 

> Back to the smart-archive-dir branch (merged), I've been playing with it
> and I think it should do things a bit differently, namely:
> 
>   --archive-dir  changes the base dir (default ~/.duplicity)
>   --name         changes the sub-dir name (default hash of URL)
> 
> In any use case, the path to the archive dir is given by:
>   os.path.join(globals.archive_dir, globals.backup_name)
> 
> Right now, you can change archive dir, but it loses name, or you can
> leave the default archive dir and either use the name or the hash.
> 
> This gives us great flexibility, and to me is less confusing.
> 
> Thoughts?

Sounds good to me; in reality it's basically changing the abstraction
of the archive dir to better match the current/future use of it to
contain potentially arbitrary stuff.

I wonder if we should in fact also rename --archive-dir to something
else (retaining --archive-dir as a compatibility option) to better
reflect it's use? The trouble with that though is that a new name is
likely not going to play well with a future separation as per
Michael's suggestion - so perhaps better not do any renaming.

Anyways, yes, I think it all becomes cleaner that way. %...% expansion
in and of itself always felt hacky.

Shall I go ahead and make the change?

-- 
/ Peter Schuller

PGP userID: 0xE9758B7D or 'Peter Schuller <peter.schuller@xxxxxxxxxxxx>'
Key retrieval: Send an E-Mail to getpgpkey@xxxxxxxxx
E-Mail: peter.schuller@xxxxxxxxxxxx Web: http://www.scode.org

Attachment: pgpBiAd7FLiIn.pgp
Description: PGP signature


References