← Back to team overview

duplicity-team team mailing list archive

Re: [Merge] lp:~breunigs/duplicity/amazondrive into lp:duplicity

 

Review: Needs Fixing

hi Stefan,

1.
as your amazon backend is based on https access i would advise to give it following protocol prefixes
acd+https
acd

this is similar to eg. ssh backends where there exist several alternative backends. the acd prefix would then be the default if we decide to make it the default backend for amazon of course.

2.
please add the required python libs to the manpage under 'Requirements'

3.
calling the backend 'Amazon Cloud Drive' will probably more accurate and closer to the older backends naming. after all both are accessing the same storage service.

4. (optional)
not sure how, but acdcli backend seems to be completely undocumented in the manpage. if you don't mind please add the needed lines under 'URL Format', 'Requirements' and explain switching under 'A Note on...'.

so far, thx!.. ede/duply.net


-- 
https://code.launchpad.net/~breunigs/duplicity/amazondrive/+merge/309084
Your team duplicity-team is subscribed to branch lp:duplicity.


References