← Back to team overview

fuel-dev team mailing list archive

Re: [Mellanox] Mellanox commits need code reviews

 

Dudu, Eli,

We are currently discussing the option of sticking to July 10th feature
freeze date for core features, but giving you guys feature freeze exception
to get the code merged until July 16th.

I believe it's going to be much more than just addressing -1s though.
Specifically, as I mentioned -- waiting for qemu 2.0 (waiting for core team
to complete), ML2 (waiting for core team to complete), you will have to
re-test, make changes to your code to adapt to ML2, your packages have to
be added to our repos, etc.

>> I don’t see any special risks with our code
Your code looks fairly isolated. The biggest risk that we see if
modification of bootstrap image where mlx4_en gets unconditionally loaded.
One of our engineers have seen an issue where VM (he has testing under KVM)
would start consuming 100% CPU when mlx4_en is loaded, and would drop to 0%
when it gets unloaded. We are not sure if this is always reproducible,
whether it's going to affect any internal CI/CD tests, whether or not it
would surface in production...

Long story short, to minimize the risk we can always put a second "Mellanox
bootstrap image" on the node, and provide instructions to the end users to
activate it by overwriting the default bootstrap image.

We will keep you posted.

Thanks,
Roman


On Tue, Jul 8, 2014 at 11:01 AM, Eli Karpilovski <elik@xxxxxxxxxxxx> wrote:

>  Mirantis team,
>
>
>
> Re qemu upgrade - We are fully committed to support this issue from our
> end as we can not risk the given dates we provided our joint partner(SV)
> supporting end customer with Fuel 5.1 in few weeks.
>
>
>
> Do we need to plan our resources to work over the weekend to accommodate
> this slip/issue?
>
>
>
> Regards,
>
> Eli
>
>
>
>
>
> *From:* Dudu Slama
> *Sent:* Tuesday, July 08, 2014 10:34 AM
> *To:* Roman Alekseenkov; Nurit Vilosny; Erez Cohen; Eli Karpilovski
>
> *Cc:* fuel-dev@xxxxxxxxxxxxxxxxxxx; Moshe Levi; Gil Meir
> *Subject:* RE: [Fuel-dev] [Mellanox] Mellanox commits need code reviews
>
>
>
> +Eli, Erez
>
>
>
> *From:* Dudu Slama
> *Sent:* Tuesday, July 08, 2014 7:43 PM
> *To:* 'Roman Alekseenkov'; Nurit Vilosny
> *Cc:* fuel-dev@xxxxxxxxxxxxxxxxxxx; Moshe Levi; Gil Meir
> *Subject:* RE: [Fuel-dev] [Mellanox] Mellanox commits need code reviews
>
>
>
> Hi Roman,
>
>
>
> We have already pushed our code last Thursday and right now we just fix
> the -1 and provide some bug fixes.
>
> From my point of view we are ready to integration and we just wait for
> your commits. I don’t see any special risks with our code since we have
> tested it internally and our code should run only with mlnx plugins.
>
> We prefer to push and integrate our code this week in order to be part of
> Fuel5.1.
>
>
>
> Regards,
>
> *David Slama*
>
> Director of Cloud Solutions
>
> Mellanox Technologies
>
>
>
> dudus@xxxxxxxxxxxx
>
> office:     +972 74 712 92 16
>
> Mobile:  +972 50 313 50 13
>
> www.mellanox.com
>
>
>
>
>
> *From:* Roman Alekseenkov [mailto:ralekseenkov@xxxxxxxxxxxx
> <ralekseenkov@xxxxxxxxxxxx>]
> *Sent:* Tuesday, July 08, 2014 9:50 AM
> *To:* Nurit Vilosny
> *Cc:* fuel-dev@xxxxxxxxxxxxxxxxxxx; Dudu Slama; Moshe Levi; Gil Meir
> *Subject:* Re: [Fuel-dev] [Mellanox] Mellanox commits need code reviews
>
>
>
> Nurit,
>
>
>
> First of all, thanks for submitting the changes. I know you guys invested
> quite a bit of time into learning Fuel and creating this integration. And
> actually, we would love to have your code merged and get integration with
> Mellanox working OOB.
>
>
>
> Timeline is the real question right now. The team is working hard to get
> the things under control before 5.1 feature freeze - fix master, merge
> remaining changes, etc. Feature freeze has been already moved by a week -
> now it's July 10th, and it's very unlikely that it will be moved once again.
>
>
>
> From what I know, there are some dependencies that you rely on:
>
>    - ML2 - in process of being merged
>    - bug related to ISER - still open
>    - qemu upgrade - the team is investigating 5x performance degradation
>    right now, not clear if it's going to happen or not in 5.1
>
>  Even if all of the above gets addressed, we will need to take additional
> time to review your code (right now it's only partially reviewed), then you
> guys will need to address -1s, integrate with ML2 code, address another
> round of issues, etc. Completing all of this before Thursday sounds nearly
> impossible, so I was thinking that the next feature release may be a better
> option for introducing the integration. So we can take time and do it right.
>
>
>
> Let me know your thoughts.
>
>
>
> Thanks,
>
> Roman
>
>
>
> On Fri, Jul 4, 2014 at 7:32 AM, Nurit Vilosny <nuritv@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> Here are all Mellanox feature commits. We would appreciate if someone can
> review them and comment.
>
> 1.     https://review.openstack.org/101126
>     Added bootstrap support to Mellanox connectX 3-pro
>
> 2.     https://review.openstack.org/103425
>     Added UI changes for Mellanox features
>
> 3.     https://review.openstack.org/103427
>     Adding OFED drivers installation
>
> 4.     https://review.openstack.org/104323
>     Adding virtual port renaming in case of iSER
>
> 5.     https://review.openstack.org/104501
>     Mellanox Changes in deployment serializers
>
> 6.     https://review.openstack.org/104621
>     Adding Mellanox manifests for mellanox plugin
>
> thanks and best regards,
>
>
>
> Nurit Vilosny
>
> SW Cloud Solutions Manager
>
>
>
> Mellanox Technologies
>
> 13 Zarchin St. Raanana, Israel
>
> Office: 972-74-712-9410
>
> Cell: 972-54-471300
>
> Fax: 972-74-712-9111
>
>
>
>
> --
> Mailing list: https://launchpad.net/~fuel-dev
> Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~fuel-dev
> More help   : https://help.launchpad.net/ListHelp
>
>
>

Follow ups

References