← Back to team overview

fuel-dev team mailing list archive

Re: [Mellanox] Mellanox commits need code reviews

 

Mellanox team,

After the internal discussion we decided to make an exception for the MLNX
feature and give 1 more week  after the FF date to merge the code into the
master.

*Requirements*
MLNX code should be merged by Jul-16. In should have no critical bugs
affecting the fuel core functionality and the MLNX functionality.

*Action Plan (Jul-9 .. Jul-16)*
Mellanox - blue, Mirantis - red.

StepResponsibleDatesFuel Team commentsPut all MLNX code to git on code
review. New code won't be accepted after the FFMellanox7/10/2014Fix all
-1,-2 in MLNX code reviewsMellanox7/10/2014Fix all bugs found in the MLNX
codeMellanox7/11/2014Merge QEMU 2.0 feature to the
masterMirantis7/10/2014Expected
July 10, responsible Mike SemenovMerge ML2 feature to the masterMirantis
7/10/2014Expected July 09, responsible Vladimir KuklinCreate a special
bootstrap image for MLNXMellanox7/10/2014don't think Mirantis folks know
anything about it. I think it should be rather on MLNX side. Mirantis will
provide initial documentation / guidance on where in the code to do itUpload
all MLNX packages to the Mirantis reposMirantis7/10/2014Mellanox should
provide the source code for the packages ASAP. The OSCI team needs to
analyze it.
In worst case - Jul-16Fix all Fuel core bugs affecting the MLNX feature
Mirantis7/10/2014Rebase from the up-to-date master and test the feature
Mellanox7/13/2014Fix issues and commit the updated codeMellanox7/13/2014Review
the MLNX codeMirantis7/14/2014Make fixes after the code review and upload
new patchesMellanox7/15/2014Review the patches and merge the MLNX code into
the masterMirantis7/16/2014


   - Please pay attention that we decided to put a second "Mellanox
   bootstrap image" on the node, and provide instructions to the end users to
   activate it by overwriting the default bootstrap image. It's an Action
   Item for you to prepare it.
   - Also in order to create and upload all packages you requested we need
   the source code, so please provide it ASAP, it's a blocker.

*Risks*
Mirantis doesn't merge ML2, QEMU to the master by Jul-10Mirantis informs
Mellanox, we adjust the dates.MLNX doesn't provide the bootstrap imageMirantis
moves the Feature out of 5.1MLNX doesn't provide the source code for the
packagesMirantis can't build and upload the packages. The MLNX feature
doesn't workMLNX doesn't submit HA code by Jul-10 (not bug fixes, but new
features)HA code won't be accepted after Jul-10. The feature won't be fully
implementedMLNX code doesn't work after the master rebase (with ML2, QEMU
2.0). And the MLNX team didn't fix it by Jul-16Mirantis moves the Feature
out of 5.1MLNX code has critical bugs that affects the Fuel core
functionality. And the MLNX team didn't fix it by Jul-16Mirantis moves the
Feature out of 5.1MLNX code has critical bugs that affects the MLNX feature
functionality. And the MLNX team didn't fix it by Jul-16Mirantis moves the
Feature to Experimental modeMLNX code is not merged by Jul-16Mirantis moves
the Feature out of 5.1
*Bugs*

BugMLNX commentMirantis commentBug #1321701: Upgrade qemu version to 2.0 or
1.6[nv] ongoing. We got the new version and we will test it.Code to be
merged by Jul-10Bug #1335647: add mlnx pkgs and dependencies to Mirantis
repos[nv] Mirantis asked for source code. RPM themselves has the sources.
Waiting to see if it is good enough@MLNX: Provide the src.rpm packages.
Final RPMs are not enough. Same applies to DEB packages.
As soon as the source code provided the bug goes to the Mirantis sideBug
#1335751: CentOS required packages for Mellanox features[nv] as previous@MLNX:
Provide the src.rpm packages. Final RPMs are not enough. Same applies to
DEB packages.
As soon as the source code provided the bug goes to the Mirantis side
Bug #1336668: when installing mlnx ofed need to support oem firmware[nv]
internal bug – in progress. Will be committed by tomorrow.Bug #1336670:
provide build instructions and scripts from your GIT repository to build
Mlnx testVM[nv] internal - in progress.Bug #1336867: Mellanox Features -
need more restriction in WebUI[nv] internal - commited.Bug #1337210: ISER
is broken in upstream[nv] go the new package now. Testing – in progress.The
package provided to the MLNX teamBug #1337213: Ubuntu package nova-compute
is missing a file[nv] if need help on this - it can be done as part of our
manifests. Need to discuss if this solution is valid by you.The bug is on
the MLNX sideBug #1337456: mellanox_openstack missing ha support[nv]
internal – commited.Bug #1339577 verify network is always failling before
deplyment[nv] seems as master problems.The bug is on Fuel side. Work in
progress. The MLNX team can proceed. It shouldn't affect to merge.
*QA*
Please share the test cases and their results with the Fuel QA team. You
can use the  #fuel-qa irc channel or reach out to Anastasia Urlapova
directly (aurlapova@xxxxxxxxxxxx).

Here is the link to the spreadsheet with all information i provided in this
email: MLNX in 5.1
<https://docs.google.com/a/mirantis.com/spreadsheets/d/1Q8IFKNLHGJJK7ehz6V9msqZK3FuxectwLu2mQHhxhAQ/edit#gid=491261444>

Please feel free to add comments or ask questions.
I propose to schedule daily sync-ups. Please reach out to me directly to
discuss the time that works for you.

Thanks.

--
Evgeniya


On Wed, Jul 9, 2014 at 4:49 AM, Roman Alekseenkov <ralekseenkov@xxxxxxxxxxxx
> wrote:

> Dudu, Eli,
>
> We are currently discussing the option of sticking to July 10th feature
> freeze date for core features, but giving you guys feature freeze exception
> to get the code merged until July 16th.
>
> I believe it's going to be much more than just addressing -1s though.
> Specifically, as I mentioned -- waiting for qemu 2.0 (waiting for core team
> to complete), ML2 (waiting for core team to complete), you will have to
> re-test, make changes to your code to adapt to ML2, your packages have to
> be added to our repos, etc.
>
> >> I don’t see any special risks with our code
> Your code looks fairly isolated. The biggest risk that we see if
> modification of bootstrap image where mlx4_en gets unconditionally loaded.
> One of our engineers have seen an issue where VM (he has testing under KVM)
> would start consuming 100% CPU when mlx4_en is loaded, and would drop to 0%
> when it gets unloaded. We are not sure if this is always reproducible,
> whether it's going to affect any internal CI/CD tests, whether or not it
> would surface in production...
>
> Long story short, to minimize the risk we can always put a second
> "Mellanox bootstrap image" on the node, and provide instructions to the end
> users to activate it by overwriting the default bootstrap image.
>
> We will keep you posted.
>
> Thanks,
> Roman
>
>
> On Tue, Jul 8, 2014 at 11:01 AM, Eli Karpilovski <elik@xxxxxxxxxxxx>
> wrote:
>
>>  Mirantis team,
>>
>>
>>
>> Re qemu upgrade - We are fully committed to support this issue from our
>> end as we can not risk the given dates we provided our joint partner(SV)
>> supporting end customer with Fuel 5.1 in few weeks.
>>
>>
>>
>> Do we need to plan our resources to work over the weekend to accommodate
>> this slip/issue?
>>
>>
>>
>> Regards,
>>
>> Eli
>>
>>
>>
>>
>>
>> *From:* Dudu Slama
>> *Sent:* Tuesday, July 08, 2014 10:34 AM
>> *To:* Roman Alekseenkov; Nurit Vilosny; Erez Cohen; Eli Karpilovski
>>
>> *Cc:* fuel-dev@xxxxxxxxxxxxxxxxxxx; Moshe Levi; Gil Meir
>> *Subject:* RE: [Fuel-dev] [Mellanox] Mellanox commits need code reviews
>>
>>
>>
>> +Eli, Erez
>>
>>
>>
>> *From:* Dudu Slama
>> *Sent:* Tuesday, July 08, 2014 7:43 PM
>> *To:* 'Roman Alekseenkov'; Nurit Vilosny
>> *Cc:* fuel-dev@xxxxxxxxxxxxxxxxxxx; Moshe Levi; Gil Meir
>> *Subject:* RE: [Fuel-dev] [Mellanox] Mellanox commits need code reviews
>>
>>
>>
>> Hi Roman,
>>
>>
>>
>> We have already pushed our code last Thursday and right now we just fix
>> the -1 and provide some bug fixes.
>>
>> From my point of view we are ready to integration and we just wait for
>> your commits. I don’t see any special risks with our code since we have
>> tested it internally and our code should run only with mlnx plugins.
>>
>> We prefer to push and integrate our code this week in order to be part of
>> Fuel5.1.
>>
>>
>>
>> Regards,
>>
>> *David Slama*
>>
>> Director of Cloud Solutions
>>
>> Mellanox Technologies
>>
>>
>>
>> dudus@xxxxxxxxxxxx
>>
>> office:     +972 74 712 92 16
>>
>> Mobile:  +972 50 313 50 13
>>
>> www.mellanox.com
>>
>>
>>
>>
>>
>> *From:* Roman Alekseenkov [mailto:ralekseenkov@xxxxxxxxxxxx
>> <ralekseenkov@xxxxxxxxxxxx>]
>> *Sent:* Tuesday, July 08, 2014 9:50 AM
>> *To:* Nurit Vilosny
>> *Cc:* fuel-dev@xxxxxxxxxxxxxxxxxxx; Dudu Slama; Moshe Levi; Gil Meir
>> *Subject:* Re: [Fuel-dev] [Mellanox] Mellanox commits need code reviews
>>
>>
>>
>> Nurit,
>>
>>
>>
>> First of all, thanks for submitting the changes. I know you guys invested
>> quite a bit of time into learning Fuel and creating this integration. And
>> actually, we would love to have your code merged and get integration with
>> Mellanox working OOB.
>>
>>
>>
>> Timeline is the real question right now. The team is working hard to get
>> the things under control before 5.1 feature freeze - fix master, merge
>> remaining changes, etc. Feature freeze has been already moved by a week -
>> now it's July 10th, and it's very unlikely that it will be moved once again.
>>
>>
>>
>> From what I know, there are some dependencies that you rely on:
>>
>>    - ML2 - in process of being merged
>>    - bug related to ISER - still open
>>    - qemu upgrade - the team is investigating 5x performance degradation
>>    right now, not clear if it's going to happen or not in 5.1
>>
>>  Even if all of the above gets addressed, we will need to take
>> additional time to review your code (right now it's only partially
>> reviewed), then you guys will need to address -1s, integrate with ML2 code,
>> address another round of issues, etc. Completing all of this before
>> Thursday sounds nearly impossible, so I was thinking that the next feature
>> release may be a better option for introducing the integration. So we can
>> take time and do it right.
>>
>>
>>
>> Let me know your thoughts.
>>
>>
>>
>> Thanks,
>>
>> Roman
>>
>>
>>
>> On Fri, Jul 4, 2014 at 7:32 AM, Nurit Vilosny <nuritv@xxxxxxxxxxxx>
>> wrote:
>>
>> Hi,
>>
>> Here are all Mellanox feature commits. We would appreciate if someone can
>> review them and comment.
>>
>> 1.     https://review.openstack.org/101126
>>     Added bootstrap support to Mellanox connectX 3-pro
>>
>> 2.     https://review.openstack.org/103425
>>     Added UI changes for Mellanox features
>>
>> 3.     https://review.openstack.org/103427
>>     Adding OFED drivers installation
>>
>> 4.     https://review.openstack.org/104323
>>     Adding virtual port renaming in case of iSER
>>
>> 5.     https://review.openstack.org/104501
>>     Mellanox Changes in deployment serializers
>>
>> 6.     https://review.openstack.org/104621
>>     Adding Mellanox manifests for mellanox plugin
>>
>> thanks and best regards,
>>
>>
>>
>> Nurit Vilosny
>>
>> SW Cloud Solutions Manager
>>
>>
>>
>> Mellanox Technologies
>>
>> 13 Zarchin St. Raanana, Israel
>>
>> Office: 972-74-712-9410
>>
>> Cell: 972-54-471300
>>
>> Fax: 972-74-712-9111
>>
>>
>>
>>
>> --
>> Mailing list: https://launchpad.net/~fuel-dev
>> Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~fuel-dev
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>
>


-- 
--
Regards,
Evgeniya
Mirantis, Inc

Mob.phone: +7 (968) 760-98-42
Email: eshumakher@xxxxxxxxxxxx
Skype: eshumakher

[image: Register today: OpenStack Silicon Valley | 16 September 2014]
<http://www.openstacksv.com>

Follow ups

References