← Back to team overview

fuel-dev team mailing list archive

Re: Do we really want to update docker during the upgrade before HCF?

 

Hi David,

We understand that it isn't solution of the problem, it's just a workaround.
The ticket is there and we know that we need to fix it.

Thanks,


On Mon, Aug 25, 2014 at 6:10 PM, David Easter <deaster@xxxxxxxxxxxx> wrote:

>   The standard process for upgrade cannot be “upgrade, fail, upgrade
> again” to address the docker issue with duplicate IP addresses.   We need
> to find a better user experience than this.  The user should only have to
> run ./upgrade.sh once and expect it to work.
>
> Thanks,
>
> - David J. Easter
>   Director of Product Management,   Mirantis, Inc.
>
> From: Evgeniy L <eli@xxxxxxxxxxxx>
> Date: Monday, August 25, 2014 at 2:13 AM
> To: Meg McRoberts <mmcroberts@xxxxxxxxxxxx>
>
> Cc: "fuel-dev@xxxxxxxxxxxxxxxxxxx" <fuel-dev@xxxxxxxxxxxxxxxxxxx>
> Subject: Re: [Fuel-dev] Do we really want to update docker during the
> upgrade before HCF?
>
> Hi Meg,
>
> User should run upgrade again, let me describe how it looks like
>
> 1. user downloads tar-ball, unpacks it
> 2. runs ./upgrade.sh, it fails because of some issue,
>     then automatic rollback starts, when it's done user
>     can see the error on the screen and his previous
>     version of system is running
> 3. user wants to try again, he can run ./upgrade.sh as
>     he did it before
>
> Thanks
>
>
> On Fri, Aug 22, 2014 at 9:38 PM, Meg McRoberts <mmcroberts@xxxxxxxxxxxx>
> wrote:
>
>> Just to clarify, are the upgrade instructions for 5.1 to run upgrade.sh
>> twice
>> or are you making ./upgrade.sh run itself twice for one user command?
>>
>> I just created https://bugs.launchpad.net/fuel/+bug/1360372 to cover the
>> 5.1 upgrade instructions.
>>
>>
>> On Fri, Aug 22, 2014 at 6:44 AM, Evgeniy L <eli@xxxxxxxxxxxx> wrote:
>>
>>> Created a ticket [1] for osci team to remove new package
>>> from the repo, in this case puppet won't update and restart
>>> docker.
>>>
>>> [1] https://bugs.launchpad.net/fuel/+bug/1360274
>>>
>>>
>>> On Fri, Aug 22, 2014 at 5:25 PM, Mike Scherbakov <
>>> mscherbakov@xxxxxxxxxxxx> wrote:
>>>
>>>> Jus run upgrade again is absolutely fine for 5.1. If these are only
>>>> things required as workaround, let's revert docker upgrade.
>>>>
>>>> Mike Scherbakov
>>>> #mihgen
>>>> On Aug 22, 2014 5:15 PM, "Evgeniy L" <eli@xxxxxxxxxxxx> wrote:
>>>>
>>>>> As far as I can see the only workaround how user can
>>>>> handle it is to run upgrade again.
>>>>>
>>>>> The problem with dockerctl which cleans up some
>>>>> mount points is for 5.0.1 upgrade we didn't use dockerctl
>>>>> to start containers, we somehow have to fix it in upgrade
>>>>> script.
>>>>>
>>>>> Also I have some problems which related only to 5.0.1
>>>>> iso, I'm debugging it now, it looks like 60 seconds is
>>>>> not enough for postgres container to bring the service
>>>>> up.
>>>>>
>>>>> On Fri, Aug 22, 2014 at 3:51 PM, Matthew Mosesohn <
>>>>> mmosesohn@xxxxxxxxxxxx> wrote:
>>>>>
>>>>>> Evgeniy,
>>>>>>
>>>>>> Do you have a workaround for the duplicate IP address allocation bug?
>>>>>> We're upgrading to fix one bug and so far it seems stable to me. I
>>>>>> have a lot of workarounds in dockerctl to start these up, but it's
>>>>>> less than ideal.
>>>>>>
>>>>>> On Fri, Aug 22, 2014 at 3:42 PM, Evgeniy L <eli@xxxxxxxxxxxx> wrote:
>>>>>> > Hi,
>>>>>> >
>>>>>> > Several days ago we got patched docker where was fixed a problem [1]
>>>>>> > with IPs duplication during containers run. But upgrading of docker
>>>>>> > seemed to be risky and it's appeared to be risky, we got several
>>>>>> bugs [2],
>>>>>> > [3].
>>>>>> > The problem is when we upgrade docker, it stops all of the
>>>>>> containers,
>>>>>> > and it starts them again after update, and restart of docker is
>>>>>> buggy and
>>>>>> > has side effects [4].
>>>>>> >
>>>>>> > I'm not sure if it's a full list of problems which we can have with
>>>>>> docker
>>>>>> > update.
>>>>>> > I would like to suggest not to update docker in the current release
>>>>>> and
>>>>>> > try to make another workaround for the issue with ip duplication.
>>>>>> > I'll try to handle docker update on upgrade system side, but I'm
>>>>>> not sure
>>>>>> > if will have enough time to test it properly.
>>>>>> >
>>>>>> > Thanks
>>>>>> >
>>>>>> > [1] https://github.com/docker/docker/pull/5783
>>>>>> > [2] https://bugs.launchpad.net/fuel/+bug/1360146
>>>>>> > [3] https://bugs.launchpad.net/fuel/+bug/1360161
>>>>>> > [4] https://github.com/docker/docker/issues/6675
>>>>>> >
>>>>>> >
>>>>>> > --
>>>>>> > Mailing list: https://launchpad.net/~fuel-dev
>>>>>> > Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
>>>>>> > Unsubscribe : https://launchpad.net/~fuel-dev
>>>>>> > More help   : https://help.launchpad.net/ListHelp
>>>>>> >
>>>>>>
>>>>>> --
>>>>>> Mailing list: https://launchpad.net/~fuel-dev
>>>>>> Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~fuel-dev
>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Mailing list: https://launchpad.net/~fuel-dev
>>>>> Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~fuel-dev
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>
>>> --
>>> Mailing list: https://launchpad.net/~fuel-dev
>>> Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~fuel-dev
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
> -- Mailing list: https://launchpad.net/~fuel-dev Post to :
> fuel-dev@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~fuel-dev
> More help : https://help.launchpad.net/ListHelp
>

References