gtg team mailing list archive

[Jeff Oliver <kaiserfro@xxxxxxxxx>]

I modified some code to get a idea of what is going on. What I'm seeing
is that the filter is getting very deep into processing the nodes that
it stacks up lots of nodes in the "wait" queue waiting for its root to
be added.  Then when the root is finally added, it only processes 1 on
the stack, which cannot be added since its root was not added.
Ultimately, there are not enough iterations through the list of nodes to
empty out the wait queue.  The messed up thing is that the wait queue
contains things after it thinks its complete which affects other
filters.

Somehow the wait queue needs to be emptied before it can stop.  Also, in
my opinion, this seems like a brute force way of dealing with a tree,
the simple fix would be to grind through the wait list until its empty
and all of the nodes have been added, however I the processing time to
do such a thing would be astronomical.  Surely there is a better way.

Ok, I modified the filtertree.py a little bit:

    def __add_node(self,tid,inroot=None):
        print tid
        if not self.is_displayed(tid):
            print "added1"
            node = self.get_node(tid)
            if inroot == None:
                inroot = self.__is_root(node)
            #If the parent's node is not already displayed, we wait
            if not inroot and not self.node_parent(node):
                print "added2"
                self.node_to_add.append(tid)
            else:
                print "added3"
                self.add_count += 1
                self.__nodes_count += 1
                self.__root_update(tid,inroot)
                self.displayed_nodes.append(tid)
                self.emit("task-added-inview", tid)
                #We added a new node so we can check with those waiting
                if len(self.node_to_add) > 0:
                    print "added4"
                    n = self.node_to_add.pop(0)
                    #node still to add cannot be root
                    self.__add_node(n,False)

For the bad filter, i get the following output:


applying filter @BC
127@1
added1
added2
11@1
added1
added2
10@1
added1
added2
99@1
added1
added2
7@1
added1
added2
120@1
added1
added2
94@1
added1
added2
5@1
added1
added2
64@1
added1
added2
18@1
added1
added2
95@1
added1
added2
105@1
added1
added2
156@1
added1
added2
173@1
added1
added2
132@1
added1
added2
157@1
added1
added2
133@1
added1
added2
298@1
added1
added2
14@1
added1
added2
101@1
added1
added2
9@1
added1
added2
83@1
added1
added2
84@1
added1
added2
8@1
added1
added2
6@1
added1
added2
109@1
added1
added2
80@1
added1
added2
104@1
added1
added2
304@1
added1
added2
297@1
added1
added2
128@1
added1
added2
97@1
added1
added2
92@1
added1
added2
129@1
added1
added2
115@1
added1
added2
87@1
added1
added2
119@1
added1
added2
93@1
added1
added2
283@1
added1
added2
47@1
added1
added3
added4
127@1
added1
added2
124@1
added1
added2
13@1
added1
added2
121@1
added1
added2
12@1
added1
added2
98@1
added1
added2
122@1
added1
added3
added4
11@1
added1
added2
146@1
added1
added2
96@1
added1
added2
136@1
added1
added2
145@1
added1
added2
134@1
added1
added2
135@1
added1
added2
305@1
added1
added2
295@1
added1
added2
103@1
added1
added2
130@1
added1
added3
added4
10@1
added1
added2
131@1
added1
added3
added4
99@1
added1
added2
16@1
added1
added3
added4
7@1
added1
added2
81@1
added1
added3
added4
120@1
added1
added2
82@1
added1
added2
296@1
added1
added2
184@1
added1
added2
102@1
added1
added2
79@1
added1
added2
196@1
added1
added3
added4
94@1
added1
added2
289@1
added1
added2
112@1
added1
added2
90@1
added1
added2
113@1
added1
added2
106@1
added1
added2
91@1
added1
added2
116@1
added1
added2
88@1
added1
added2
89@1
added1
added2
117@1
added1
added2
85@1
added1
added2
86@1
added1
added2
100@1
added1

-- 
[gtg-refactor] Subtasks missing in task tree
https://bugs.launchpad.net/bugs/552098
You received this bug notification because you are a member of Gtg
contributors, which is subscribed to Getting Things GNOME!.

Status in Getting Things GNOME!: Incomplete

Bug description:
Using trunk revision 712.

Simply put, the subtasks for a task do no show up in the task list.  The subtask count is correct for the task in the tree view, however not all of the subtasks are visible.

Opening up the task and closing will refresh the tree view and the missing tasks appear again.  

Switching to a filtered view by selecting a tag from the tag pane can cause the problem to appear again, of course opening up the task fixes the missing subtasks.

By the same token, subtasks of subtasks are also missing, opening up the subtask fixes the children.

I don't see any consistent behavior as to which tasks appear vs. which are missing.