gtg team mailing list archive

[Chenxiong Qi <qcxhome@xxxxxxxxx>]

On Fri, Aug 30, 2013 at 2:14 PM, Xuan (Sean) Hu <huxuan8218528@xxxxxxxxx>wrote:

> Hi, Chenxiong Qi,
>
> Thx for your bug reporting and fixing. This problem tends to be caused by
> my last merge. :-(
> It's really great for you to follow my porting progress and give feedback
> so quickly. :-)
>
> I create a class TaskConfig to wrap all functions needed for task
> configuration.
> And I would like to suggest to see if this bug can be fixed in
> TaskConfig.get [1] instead of writing the same code for multiple times.
>
>
Hi Xuan,

Sure. We should avoid writing same code many times. However, from the name
TaskConfig I guess it might be a general class to access configurations of
a task. In this case, line 163 in the code is not proper in my opinion due
to not all potential configuration value has the same format as position
and size. It is also necessary to consider the generic of TaskConfig's
interface. What do you say? :)

Regards,
Chenxiong Qi



> [1]
> http://bazaar.launchpad.net/~gtg/gtg/trunk/view/head:/GTG/core/__init__.py#L163
> --
> https://code.launchpad.net/~qcxhome/gtg/bugfix-1218708/+merge/183075
> You are the owner of lp:~qcxhome/gtg/bugfix-1218708.
>



-- 
A Python developer living in Beijing
http://about.me

https://code.launchpad.net/~qcxhome/gtg/bugfix-1218708/+merge/183075
Your team Gtg developers is requested to review the proposed merge of lp:~qcxhome/gtg/bugfix-1218708 into lp:gtg.