← Back to team overview

holland-coredev team mailing list archive

[Bug 1017596] Re: Holland purge policy before backup not accounted in dry run space estimation

 

I have relaxed the estimation check to only log a message rather than
abort the dry-run process completely when there is insufficient space.
The commit that changed this is here:

https://github.com/holland-
backup/holland/commit/b53cc48c5c60d0f77c2ebe914456ec3ee00ed9b3

The same error message is logged during a dry-run but we continue on
anyway.   An additional message notes that space may actually be
available during a real backup depending on the purge-policy setting.
This allows seeing other dry-run errors from the actual backup strategy
being used rather than always stopping on the estimation step.

This is an easy fix for now.   Perhaps holland can do something more
sophisticated in the future.

** Changed in: holland-backup
       Status: New => Fix Committed

** Changed in: holland-backup
   Importance: Undecided => High

** Changed in: holland-backup
     Assignee: (unassigned) => Andrew Garner (muzazzi)

** Changed in: holland-backup
    Milestone: None => 1.0.8

-- 
You received this bug notification because you are a member of Holland
Build, which is subscribed to holland-backup.
https://bugs.launchpad.net/bugs/1017596

Title:
  Holland purge policy before backup not accounted in dry run space
  estimation

Status in Holland Backup Framework:
  Fix Committed

Bug description:
  Holland purge policy before backup is not accounting in dry run space
  estimation that the previous will be purged. If you will have
  sufficient free space after the "before" purge for a successful
  backup, the dry run indicates a failure will occur due to insufficient
  storage

To manage notifications about this bug go to:
https://bugs.launchpad.net/holland-backup/+bug/1017596/+subscriptions


References