hugin-bug-hunters team mailing list archive
-
hugin-bug-hunters team
-
Mailing list archive
-
Message #04798
[Bug 1256972] [NEW] tiff.c:847: possible bad if test ?
Public bug reported:
I just ran the static analysis tool cppcheck over the source code
of libpano13-2.9.18. It said
[tiff.c:847] -> [tiff.c:847]: (style) Same expression on both sides of
'||'.
Source code is
if (metadata->xPixelsPerResolution == 0 ||
metadata->xPixelsPerResolution == 0)
Maybe
if (metadata->xPixelsPerResolution == 0 ||
metadata->yPixelsPerResolution == 0)
might be better code.
** Affects: panotools
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Hugin Bug
Hunters, which is subscribed to Panotools.
https://bugs.launchpad.net/bugs/1256972
Title:
tiff.c:847: possible bad if test ?
Status in Panorama Tools:
New
Bug description:
I just ran the static analysis tool cppcheck over the source code
of libpano13-2.9.18. It said
[tiff.c:847] -> [tiff.c:847]: (style) Same expression on both sides of
'||'.
Source code is
if (metadata->xPixelsPerResolution == 0 ||
metadata->xPixelsPerResolution == 0)
Maybe
if (metadata->xPixelsPerResolution == 0 ||
metadata->yPixelsPerResolution == 0)
might be better code.
To manage notifications about this bug go to:
https://bugs.launchpad.net/panotools/+bug/1256972/+subscriptions
Follow ups
References