hypedyn-team team mailing list archive

[Alex Mitchell <944705@xxxxxxxxxxxxxxxxxx>]

** Changed in: hypedyn
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of HypeDyn
Team, which is subscribed to HypeDyn.
Matching subscriptions: HypeDyn bugs
https://bugs.launchpad.net/bugs/944705

Title:
  mistake in fall-through of rules

Status in HypeDyn:
  Fix Released

Bug description:
  From Teong Leong:

  I have made some mistakes in fall through of rules.

  we agreed that if a rule has fall_through set to false, then when this
  rule is activated, the rest of the rule would not be considered for
  activation. So activation should mean an action from this rule got
  fired by the current event triggering.

  there are two places that is wrong.
  1)  is where rules are being triggered reader-pane.scm(657)
  rule-check-trigger. it just fire whatever actions is inside without
  checking whether any action is successfully fired. It might turn out
  that no actions were relevant to this event and none got fire but it
  is still stopped from falling through. so do-rule-action in there
  somehow must return an indicator whether an action fired before
  enforcing fall-through.

  2) this is where i check whether follow-link-available? which use
  find-action reader-pane.scm(62). This goes through the rules checking
  if the follow link action is reachable. reachable meaning condition
  for the follow link action is satisfied and there weren't any rules
  before that would have actions getting fired. This feels a little
  messy. I thought it was enough to just check whether the rules before
  had conditions satisfied and whether they are blocking or not. But it
  seems I would need to check whether actions from the rules before
  should be triggered by the displayedNode event.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hypedyn/+bug/944705/+subscriptions