← Back to team overview

indicator-sound-developers team mailing list archive

Re: Playlists support

 

Hi Vsevolod,

I'm on holidays for the next week. Therefore won't be able to look at this until the beginning of the week commencing on the 24th.
Hope this is okay.

Conor


On 14/01/11 20:39, Vsevolod Velichko wrote:
Hi all.

I've just implemented playlists support in mpd-sound-menu[1] and gave
it a little test. I suppose that results shouldn't be posted as bugs,
since as I understand that it's not final version. However there is a
list of things I noted:
1. indicator-sound goes completely mad if application sends incorrect
data through DBus.Once I've send incorrect structure in ActivePlaylist
property and it made indicator-sound reread properties in an infinite
loop. The indicator itself is unavailable at that moment and the sound
icon shows "muted" state.
2. Playlists are cached and old records are not removed, even between
application restarts. For example, I'll create playlists "a" and "b".
Then I'll delete the "a" playlist, add the "c" playlist and restart
mpd-sound-menu. There will be "a", "b" and "c" displayed in the
"choose playlist" menu.
3. Finally, I see no way to inform user about available playlists
change. There is only one meaningful property, informing about
playlists - PlaylistCount. It can throw corresponding
PropertiesChanged, but what we have to do if playlist neither added
nor removed, if playlist just renamed? Well, I think I could throw
signal about PlaylistCount change even when the count of playlists
remains the same, but (and this is another bug I see) indicator-sound
completely ignores that signal. As I found it reads list of playlists
only once at start.

I have to add that everything was tested on version 0.5.5-0ubuntu1 of
indicator-sound, since natty repository is broken now and I can't
update to the latest version.
Conor has mentioned yesterday that 0.5.5-0ubuntu1 should be suitable
for playlists testing so I suppose that all that bugs are still not
fixed.

Will be happy if one can propose the way to inform indicator-sound
about renamed playlists :)

[1] https://launchpad.net/~torkvemada/+archive/torkvemada

----
Best wishes and have a nice day,
Vsevolod Velichko

_______________________________________________
Mailing list: https://launchpad.net/~indicator-sound-developers
Post to     : indicator-sound-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~indicator-sound-developers
More help   : https://help.launchpad.net/ListHelp



References