kernel-packages team mailing list archive

[Colin Ian King <1434528@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

SRU Justification:

[Impact]
Minor impact: It is possible to introduce a newline into the btrfs label output from the btrfs sys file /sys/fs/btrfs/$UUID/label, this newline should be filtered out.

[Fix]
clean upstream cherry pick 48fcc3ff7dce0138c053833adf81670494f177f3 "btrfs: label should not contain return char".

[Testcase]
The commit contains a suitable testcase, see below:

TEST_DEV=/dev/vdb
TEST_DIR=/home/sat/mnt

umount /home/sat/mnt

mkfs.btrfs -f $TEST_DEV
UUID=$(btrfs fi show $TEST_DEV | head -1 | sed -e 's/.*uuid: \([-0-9a-z]*\)$/\1/')
mount $TEST_DEV $TEST_DIR
LABELFILE=/sys/fs/btrfs/$UUID/label

echo "Test for empty label..." >&2
LINES="$(cat $LABELFILE | wc -l | awk '{print $1}')"
RET=0

if [ $LINES -eq 0 ] ; then
    echo '[PASS] Trailing \n is removed correctly.' >&2
else
    echo '[FAIL] Trailing \n still exists.' >&2
    RET=1
fi

echo "Test for non-empty label..." >&2

echo testlabel >$LABELFILE
LINES="$(cat $LABELFILE | wc -l | awk '{print $1}')"

if [ $LINES -eq 1 ] ; then
    echo '[PASS] Trailing \n is removed correctly.' >&2
else
    echo '[FAIL] Trailing \n still exists.' >&2
    RET=1
fi

exit $RET

This is to be SRU'd for utopic only, trusty does not have this interface
supported and this fix is carried in vivid.

** Affects: linux (Ubuntu)
     Importance: Low
     Assignee: Colin Ian King (colin-king)
         Status: In Progress

** Changed in: linux (Ubuntu)
   Importance: Undecided => Low

** Changed in: linux (Ubuntu)
       Status: New => In Progress

** Changed in: linux (Ubuntu)
     Assignee: (unassigned) => Colin Ian King (colin-king)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1434528

Title:
  [utopic] btrfs: label should not contain return char

Status in linux package in Ubuntu:
  In Progress

Bug description:
  SRU Justification:

  [Impact]
  Minor impact: It is possible to introduce a newline into the btrfs label output from the btrfs sys file /sys/fs/btrfs/$UUID/label, this newline should be filtered out.

  [Fix]
  clean upstream cherry pick 48fcc3ff7dce0138c053833adf81670494f177f3 "btrfs: label should not contain return char".

  [Testcase]
  The commit contains a suitable testcase, see below:

  TEST_DEV=/dev/vdb
  TEST_DIR=/home/sat/mnt

  umount /home/sat/mnt

  mkfs.btrfs -f $TEST_DEV
  UUID=$(btrfs fi show $TEST_DEV | head -1 | sed -e 's/.*uuid: \([-0-9a-z]*\)$/\1/')
  mount $TEST_DEV $TEST_DIR
  LABELFILE=/sys/fs/btrfs/$UUID/label

  echo "Test for empty label..." >&2
  LINES="$(cat $LABELFILE | wc -l | awk '{print $1}')"
  RET=0

  if [ $LINES -eq 0 ] ; then
      echo '[PASS] Trailing \n is removed correctly.' >&2
  else
      echo '[FAIL] Trailing \n still exists.' >&2
      RET=1
  fi

  echo "Test for non-empty label..." >&2

  echo testlabel >$LABELFILE
  LINES="$(cat $LABELFILE | wc -l | awk '{print $1}')"

  if [ $LINES -eq 1 ] ; then
      echo '[PASS] Trailing \n is removed correctly.' >&2
  else
      echo '[FAIL] Trailing \n still exists.' >&2
      RET=1
  fi

  exit $RET

  This is to be SRU'd for utopic only, trusty does not have this
  interface supported and this fix is carried in vivid.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1434528/+subscriptions