← Back to team overview

kicad-developers team mailing list archive

Re: Re: Checking in broken code



This is too much dialog about one line of code. My opinion flipped last night. I agree that the one line of code should be re-written. If it was more than that I would possibly think otherwise.

BTW, version 2.8 is not adequate. With that one line of code in there, we are depending on something greater than 2.8.1, which means either 2.8.2, or 2.8.3 minimum. Obviously 2.8.4 also has the required function.

The problem function being used was added at either 2.8.2 or 2.8.3, I am not sure.

I simply think we should rewrite that one line code for now and try and stick to *2.6 API*, although using the 2.6 API does not preclude actually linking to a 2.8.x library, statically or dynamically.

Maybe instead of all this talk we should be looking at a way to rewrite that code for JP, if he has not done it already.


Follow ups