← Back to team overview

kicad-developers team mailing list archive

Re: Re: OSX suggestions.

 

Can you please put comments into each #if[n]def so that I can understand the purpose of each. Maybe we can find common ground here, code which could work on windows, linux and osx. But I have to understand your objectives of each change.

Then please re-submit the patch.

Thanks,

Dick


Index: common/msgpanel.cpp
===================================================================
--- common/msgpanel.cpp	(revision 949)
+++ common/msgpanel.cpp	(working copy)
@@ -43,9 +43,9 @@
/*************************************************/
{
wxPaintDC dc( this );
-
- //EraseMsgBox( &dc );
-
+#ifdef __WXMAC__
+ EraseMsgBox( &dc );
+#endif
dc.SetBackground( *wxBLACK_BRUSH );
dc.SetBackgroundMode( wxSOLID );

@@ -136,8 +136,11 @@
{
m_Items.push_back( item );
}
- +#ifndef __WXMAC__ showItem( dc, item ); +#else + this->Refresh();
+#endif
}


@@ -172,9 +175,14 @@
/* Effacement de la fenetre d'affichage des messages de bas d'ecran
*/
{
+#ifndef __WXMAC__
wxClientDC dc( this );

EraseMsgBox( &dc );
+#else
+ m_Items.clear();
+ this->Refresh();
+#endif
}


@@ -200,7 +208,8 @@
DC->DrawRectangle( 0, 0, size.x, size.y );
DC->SetBrush( wxNullBrush );
DC->SetPen( wxNullPen );
- +#ifndef __WXMAC__ m_Items.clear();
+#endif
}


------------------------------------

Yahoo! Groups Links







--
Best Regards,

Dick


I pray we can elect a U.S. President that has the common sense to enforce our
existing immigration laws and stop the invasion from Mexico.







Follow ups

References