← Back to team overview

kicad-developers team mailing list archive

simple fix

 

--0-1820551103-1214859436=:48576 Content-Type: text/plain; charset=us-ascii

Hi All,

Attached is a diff file that fixes a minor issue with Kicad. When a pdf viewer is not defined in the config file, clicking on the Preferences->PDF Browser->Default PDF Viewer does nothing. I've adjusted the code so an error message comes up, and then the browse for executable dialog comes up. This is the same functionality if the Preferences->PDF Browser->Favourite PDF Browser. The file is kicad/preferences.cpp

Also, I have a question on process. When fixing little bugs you find, are we suppose to file a bug report in the sourceforge bug tracker, then fix. Or just do the fix and submit?

 --0-1820551103-1214859436=:48576 Content-Type: application/octet-stream; name="preferences.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="preferences.diff"

[Attachment content not displayed.] --0-1820551103-1214859436=:48576-- 




Follow ups