kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #01817
Re: Patch for specctra session import bug
-
To:
kicad-devel@xxxxxxxxxxxxxxx
-
From:
"Brian Sidebotham" <brian.sidebotham@...>
-
Date:
Wed, 17 Sep 2008 17:55:01 +0100
-
In-reply-to:
<48D12F58.4040707@...>
2008/9/17 Dick Hollenbeck <dick@...>:
>
>> Hi Dick,
>>
>> Thanks for your pointers. At first I had assumed that isSymbol was
>> only used for components, but it is indeed used in all sorts of other
>> places. I have attached a second patch which moves this test to
>> doCOMPONENT.
>>
>> I again tested this with my board and the session is correctly
>> imported with this patch.
>>
>> Thanks for checking the Specctra grammar as I do not have that to hand.
>>
>> Best Regards,
>>
>> Brian Sidebotham.
>>
>
> Brian,
>
>
> Sorry I have to ask, but did you first remove the prior change before
> you did your testing with the new one? Just off hand a quick review of
> doPLACE() made me ask, surprized we did not need a similar test there.
>
>
> The specctra grammar file is now here:
>
> http://tech.groups.yahoo.com/group/kicad-users/files/ then file
> "specctra.pdf"
>
>
> If yes, just let me know and I will commit this patch.
>
>
> Thanks,
>
> Dick
Hi Dick,
Yes, I reverted before making the second change. The reason place does
not fall over is because it is dealing with reference designators and
not module names.
A snippet from the session file is below:
(session 5560.ses
(base_design 5560.dsn)
(placement
(resolution mil 100)
(component 0805
(place C49 521250 -216830 front 0)
Incidentally, component is the only place where the 0805 module name
is mentioned in the session file.
Again, thanks for the pointer to the specctra pdf. I will grab it so
that I have it at hand in the future.
Best Regards,
Brian Sidebotham.
Follow ups
References