← Back to team overview

kicad-developers team mailing list archive

Bug 2610468 Patch - Modedit crash on copy block


--000e0cd250167ea3df046327a82e Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi Guys,

As reported in the bug report on sourceforge, Modedit crashes (enters
an infinite loop) when copying a block containing pads. This is
present in the release candidate and SVN.

The problem was marking the new copy of a pad as selected and then
adding it to the end of the linked list, whilst in a loop traversing
the list. Hence, this creates an infinite loop and Modedit forever
creates new pads.

The patch is very small and hopefully obvious. The fix is done by
adding the new pads at the start of the list instead of at the end.

Built and tested on Windows XP.

Best Regards,

 --000e0cd250167ea3df046327a82e Content-Type: application/octet-stream; name="kicad_modeditpadcopy.patch"
Content-Disposition: attachment; filename="kicad_modeditpadcopy.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_frbcjngd0

[Attachment content not displayed.] --000e0cd250167ea3df046327a82e-- 

Follow ups