kicad-developers team mailing list archive

[Dick Hollenbeck <dick@...>]

Jean-Pierre,

Why the changes in Rev: 1723 to specctra.cpp?

What we lost was the ability of the translator to put the filename 
anywhere in the sentence? Some languages are formulated differently, 
and putting the filename at the end of the output string may not always 
be appropriate.


Something going wrong with GetData()? There is the new

*wxString::wchar_str*()

function which probably serves the same purpose.

If there was some compelling reason to take the %s out of the 
translatable format string, (and I do not think there is), then why ask 
the translator to translate the \" quote character in the new 
translatable format string?

Dick




if( !fp )
{
- ThrowIOError( _("Unable to open file \"%s\""), 
filename.GetData() );
+ ThrowIOError( _("Unable to open file \"") + filename +wxT("\"") );
}

file.Attach( fp ); // "exception safe" way to close the file.
@@ -351,7 +351,7 @@

if( !fp )
{
- ThrowIOError( _("Unable to open file \"%s\""), 
filename.GetData() );
+ ThrowIOError( _("Unable to open file \"") + filename + 
wxT("\"") );
}

file.Attach( fp ); // "exception safe" way to close the file.
@@ -3465,7 +3465,7 @@
}

if( result<0 || (result=vfprintf( fp, fmt, args ))<0 )
- ThrowIOError( _("System file error writing to file \"%s\""), 
filename.GetData() );
+ ThrowIOError( _("System file error writing to file \"") + 
filename + wxT("\"") );

va_end( args );

@@ -3521,7 +3521,7 @@

if( !fp )
{
- ThrowIOError( _("Unable to open file \"%s\""), 
filename.GetData() );
+ ThrowIOError( _("Unable to open file \"") + filename + wxT("\"") );
}

if( pcb )
@@ -3546,7 +3546,7 @@

if( !fp )
{
- ThrowIOError( _("Unable to open file \"%s\""), 
filename.GetData() );
+ ThrowIOError( _("Unable to open file \"") + filename + wxT("\"") );
}

if( session )