kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #02395
Re: changes to specctra.cpp
-
To:
kicad-devel@xxxxxxxxxxxxxxx
-
From:
"jean-pierre.charras@..." <jean-pierre.charras@...>
-
Date:
Thu, 16 Apr 2009 18:55:24 +0200
-
In-reply-to:
<49E75840.4040806@...>
-
User-agent:
Thunderbird 2.0.0.21 (Windows/20090302)
Dick Hollenbeck a écrit :
>
>
> Jean-Pierre,
>
> Why the changes in Rev: 1723 to specctra.cpp?
>
> What we lost was the ability of the translator to put the filename
> anywhere in the sentence? Some languages are formulated differently,
> and putting the filename at the end of the output string may not always
> be appropriate.
>
> Something going wrong with GetData()? There is the new
>
> *wxString::wchar_ str*()
>
> function which probably serves the same purpose.
>
> If there was some compelling reason to take the %s out of the
> translatable format string, (and I do not think there is), then why ask
> the translator to translate the \" quote character in the new
> translatable format string?
>
> Dick
>
This is a not well done work. Sorry.
Since 3 or 4 days, i am testing wxWidgets 2.9 (i.e. devel version of
wxWidgets 3.0)
ThrowIOError( _("Unable to open file \"%s\""), filename.GetData() );
does not work
( non-POD error)
*wxString::wchar_ str*() does not change anything.
This is the reason of my changes.
But:
wxString msg;
msg.Printf( _("Unable to open file \"%s\""), filename.GetData() );
ThrowIOError( msg );
works.
So i committed a new change using this syntax.
--
Jean-Pierre CHARRAS
Maître de conférences
Directeur d'études 2ieme année.
Génie Electrique et Informatique Industrielle 2
Institut Universitaire de Technologie 1 de Grenoble
BP 67, 38402 St Martin d'Heres Cedex
Recherche :
GIPSA-LIS - INPG
Rue de la Houille Blanche
38400 Saint Martin d'Heres
--------------040401070900000700080503 Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Dick Hollenbeck a écrit :
<blockquote cite="mid:49E75840.4040806@..." type="cite">
<meta http-equiv="Context-Type"
content="text/html; charset=ISO-8859-1">
<div>
<div>
<div> <br>
<br>
<p>Jean-Pierre,<br>
<br>
Why the changes in Rev: 1723 to specctra.cpp?<br>
<br>
What we lost was the ability of the translator to put the filename <br>
anywhere in the sentence? Some languages are formulated differently, <br>
and putting the filename at the end of the output string may not always
<br>
be appropriate.<br>
<br>
Something going wrong with GetData()? There is the new<br>
<br>
*wxString::wchar_ str*()<br>
<br>
function which probably serves the same purpose.<br>
</p>
</div>
</div>
</div>
</blockquote>
<blockquote cite="mid:49E75840.4040806@..." type="cite">
<div>
<div>
<div>
<p>If there was some compelling reason to take the %s out of the <br>
translatable format string, (and I do not think there is), then why ask
<br>
the translator to translate the \" quote character in the new <br>
translatable format string?<br>
<br>
Dick<br>
</p>
</div>
</div>
</div>
</blockquote>
This is a not well done work. Sorry.<br>
<br>
Since 3 or 4 days, i am testing wxWidgets 2.9 (i.e. devel version of
wxWidgets 3.0)<br>
<br>
ThrowIOError( _("Unable to open file \"%s\""), filename.GetData() );
does not work<br>
( non-POD error)<br>
<br>
*wxString::wchar_ str*() does not change anything.<br>
<br>
This is the reason of my changes.<br>
<br>
But:<br>
wxString msg;<br>
msg.Printf( _("Unable to open file \"%s\""), filename.GetData() );<br>
ThrowIOError( msg );<br>
works.<br>
<br>
So i committed a new change using this syntax.<br>
<br>
<br>
<pre class="moz-signature" cols="72">--
Jean-Pierre CHARRAS
Maître de conférences
Directeur d'études 2ieme année.
Génie Electrique et Informatique Industrielle 2
Institut Universitaire de Technologie 1 de Grenoble
BP 67, 38402 St Martin d'Heres Cedex
Recherche :
GIPSA-LIS - INPG
Rue de la Houille Blanche
38400 Saint Martin d'Heres
</pre>
</body>
</html>
--------------040401070900000700080503--
Follow ups
References
