← Back to team overview

kicad-developers team mailing list archive

Re: Re: Bug 2870835 Patch - Inconsistent Label


--00163642668114e0d8047716e984 Content-Type: text/plain; charset=ISO-8859-1

D'oh! Patch attached!

> Please find a patch attached to fix this bug. All labels are now
> consistent Patrick.
> I used the last field of the text property in the schematic file which
> is currently ignored, so this is backwards compaible. It will add the
> field to the end when a schematic has been converted.
> If the patch/theory is okay, then I can update the file format docs to suit.
> The patch does the following:
> Makes all label horizontal justifications the same
> Prevents a blank label being drawn when the dialog box is cancelled
> Adds memory to the label orientation, to give normal labels the same
> operation as global and heirechical labels.
> If anything isn't suitable or should be done another way, please speak up.
> Patrick, I agree that it would probably be nicer to select the label
> type from within the dialog (it would also be nice to have a label
> preview too!). At the moment though, I just want to do some bug fixes
> from the bug tracker. There are plenty in there and most are actually
> real problems that annoy the user.
> Best Regards,
> Brian.
 --00163642668114e0d8047716e984 Content-Type: application/octet-stream; name="labels-cleanup.patch"
Content-Disposition: attachment; filename="labels-cleanup.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g1du525w0

[Attachment content not displayed.] --00163642668114e0d8047716e984--